From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49439)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XoTM3-0003I4-DB
	for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:32:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XoTLx-0003OR-8d
	for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:32:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58778)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XoTLx-0003OL-10
	for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:32:37 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAC8WaK6000911
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 12 Nov 2014 03:32:36 -0500
Message-ID: <54631B21.60103@redhat.com>
Date: Wed, 12 Nov 2014 09:32:33 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1415712873-29274-1-git-send-email-mreitz@redhat.com>
	<1415712873-29274-2-git-send-email-mreitz@redhat.com>
	<5462E4F2.2030300@redhat.com>
In-Reply-To: <5462E4F2.2030300@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] chardev: Add -qmp-pretty
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 2014-11-12 at 05:41, Eric Blake wrote:
> On 11/11/2014 06:34 AM, Max Reitz wrote:
>> Add a command line option for adding a QMP monitor using pretty JSON
>> formatting.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   qemu-options.hx |  8 ++++++++
>>   vl.c            | 15 ++++++++++-----
>>   2 files changed, 18 insertions(+), 5 deletions(-)
>>
> Minor grammar suggestions:
>
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index da9851d..bc7b4c2 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -2788,6 +2788,14 @@ STEXI
>>   @findex -qmp
>>   Like -monitor but opens in 'control' mode.
>>   ETEXI
>> +DEF("qmp-pretty", HAS_ARG, QEMU_OPTION_qmp_pretty, \
>> +    "-qmp-pretty dev like -qmp but uses pretty JSON formatting\n",
> maybe s/dev like -qmp/dev: like -qmp,/
>
>> +    QEMU_ARCH_ALL)
>> +STEXI
>> +@item -qmp-pretty @var{dev}
>> +@findex -qmp-pretty
>> +Like -qmp but uses pretty JSON formatting.
> maybe s/-qmp/-qmp,/


That's what I wrote at first, but then I saw the entry above: "Like 
-monitor but opens in 'control' mode" and decided to stay consistent.

> Either way,
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!

Max