From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoTOG-0006Av-Ol for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:35:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoTOA-0003n3-IV for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:35:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoTOA-0003mx-Bo for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:34:54 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAC8Yrot028494 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 12 Nov 2014 03:34:53 -0500 Message-ID: <54631BAB.2030209@redhat.com> Date: Wed, 12 Nov 2014 09:34:51 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415712873-29274-1-git-send-email-mreitz@redhat.com> <1415712873-29274-4-git-send-email-mreitz@redhat.com> <5462E739.9080603@redhat.com> In-Reply-To: <5462E739.9080603@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] iotests: Use -qmp-pretty in 067 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Markus Armbruster , Stefan Hajnoczi On 2014-11-12 at 05:51, Eric Blake wrote: > On 11/11/2014 06:34 AM, Max Reitz wrote: >> 067 invokes query-block, resulting in a reference output with really >> long lines (which may pose a problem in email patches and always poses a >> problem when the output changes, because it is hard to see what has >> actually changed). Use -qmp-pretty to mitigate this issue. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/067 | 2 +- >> tests/qemu-iotests/067.out | 779 +++++++++++++++++++++++++++++++++++++++++---- >> 2 files changed, 723 insertions(+), 58 deletions(-) > Large, but mechanical. I'm trusting this one is correct (if the > testsuite still passes, you did it right) rather than actually reading it :) Yes, for me "Passes before and the output afterwards still makes sense when skipping through" was enough. Max > Reviewed-by: Eric Blake > >> diff --git a/tests/qemu-iotests/067 b/tests/qemu-iotests/067 >> index d025192..29cd6b5 100755 >> --- a/tests/qemu-iotests/067 >> +++ b/tests/qemu-iotests/067 >> @@ -39,7 +39,7 @@ _supported_os Linux >> function do_run_qemu() >> { >> echo Testing: "$@" >> - $QEMU -nographic -qmp stdio -serial none "$@" >> + $QEMU -nographic -qmp-pretty stdio -serial none "$@" > Such a trivial change for inducing over 700 lines of change in the > expected output :)