Re: [Qemu-devel] [PATCH 12/21] qcow2: Allow creation with refcount order != 4

[Max Reitz <mreitz@redhat.com>]

On 2014-11-11 at 19:05, Eric Blake wrote:
> On 11/10/2014 06:45 AM, Max Reitz wrote:
>> Add a creation option to qcow2 for setting the refcount order of images
>> to be created, and respect that option's value.
>>
>> This breaks some test outputs, fix them.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   block/qcow2.c              |  20 ++++++++
>>   include/block/block_int.h  |   1 +
>>   tests/qemu-iotests/049.out | 112 ++++++++++++++++++++++-----------------------
>>   tests/qemu-iotests/079.out |  18 ++++----
>>   tests/qemu-iotests/082.out |  41 ++++++++++++++---
>>   tests/qemu-iotests/085.out |  38 +++++++--------
>>   6 files changed, 139 insertions(+), 91 deletions(-)
> Is there any .json file that needs to be modified to allow this option
> to be set via QMP?  I guess that can be a followup.

Good point, but I can't find any JSON object which contains a 
"lazy-refcounts" (or "lazy_refcounts") field and which seems to be 
related to image creation (if "lazy-refcounts" is somewhere not relating 
to options for opening an existing image, "refcount-width" should be 
there, too). I guess there probably is no way of directly creating an 
image over QMP yet at all.

>>   qemu-img create -f qcow2 TEST_DIR/t.qcow2 -- 1kilobyte
>> -qemu-img: Invalid image size specified! You may use k, M, G, T, P or E suffixes for
>> +qemu-img: Invalid image size specified! You may use k, M, G, T, P or E suffixes for
>>   qemu-img: kilobytes, megabytes, gigabytes, terabytes, petabytes and exabytes.
> Nice that you are also getting rid of trailing whitespace.

That was actually unintentional. You seem fine with it, though, so I'll 
remove all trailing whitespace in all the test outputs I'm touching in v2.

Max

> Reviewed-by: Eric Blake <eblake@redhat.com>