From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoWJf-0008Hn-DL for qemu-devel@nongnu.org; Wed, 12 Nov 2014 06:42:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoWJW-0002NU-DJ for qemu-devel@nongnu.org; Wed, 12 Nov 2014 06:42:27 -0500 Sender: Paolo Bonzini Message-ID: <54634781.5040606@redhat.com> Date: Wed, 12 Nov 2014 12:41:53 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415791795-6779-1-git-send-email-famz@redhat.com> In-Reply-To: <1415791795-6779-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, mjt@tls.msk.ru, Markus Armbruster On 12/11/2014 12:29, Fam Zheng wrote: > The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading > comment. > > Suggested-by: Markus Armbruster > Signed-off-by: Fam Zheng > --- > include/hw/virtio/virtio-scsi.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h > index 9e1a49c..bf17cc9 100644 > --- a/include/hw/virtio/virtio-scsi.h > +++ b/include/hw/virtio/virtio-scsi.h > @@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq { > /* Note: > * - fields before elem are initialized by virtio_scsi_init_req; > * - elem is uninitialized at the time of allocation. > - * - fields after elem are zeroed by virtio_scsi_init_req. > + * - fields after elem (except the ending cdb[]) are zeroed by > + * virtio_scsi_init_req. > * */ > > VirtQueueElement elem; > Applied, thanks. Paolo