From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoYlg-00013M-EE for qemu-devel@nongnu.org; Wed, 12 Nov 2014 09:19:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoYlb-0002pj-GL for qemu-devel@nongnu.org; Wed, 12 Nov 2014 09:19:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoYlb-0002pY-81 for qemu-devel@nongnu.org; Wed, 12 Nov 2014 09:19:27 -0500 Message-ID: <54636C67.1010504@redhat.com> Date: Wed, 12 Nov 2014 07:19:19 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415627159-15941-1-git-send-email-mreitz@redhat.com> <1415627159-15941-19-git-send-email-mreitz@redhat.com> In-Reply-To: <1415627159-15941-19-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ffvKqhhpvMLHSEKMG5beu1T8git2pWtRQ" Subject: Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ffvKqhhpvMLHSEKMG5beu1T8git2pWtRQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a function qcow2_change_refcount_order() which allows changing the > refcount order of a qcow2 image. A thought: didn't you just submit a patch that marked the image as dirty, nuked the on-disk refcount, then rebuilt one using the in-memory refcounts? Would reusing THAT code be any better than writing this patch= ? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ffvKqhhpvMLHSEKMG5beu1T8git2pWtRQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUY2xnAAoJEKeha0olJ0NqF+cIAIARxuscq0FmaIse07PnxvyM a9iweA7EbRXKnKz6psMrm64aFo9Qwa1hNuaRAGDazHgBartFEQs0cjTXnbE4A8/g IzEf7pjJsTG4fxocqu5Tz/LBjI5OGaFct0PIB6woy7MRYYK+fDoDlPcHktk8vXbd n9FcY8Gsic89/9EgWfcHfxD3YSdHOJvGnoElOee11678bf1tST7SQWrJQ8GlbvMf fvVpX7fnvgyMd0j6R5GHpDYDAHdPay/zoH9W0Srzft0v7G7kduQwSMTStzO0Myo4 bhacQ7HqczPAk1uPoklBk61ule58Xwt3niik7Mu9AriGMbLQYhfMTBw6ETIB5EE= =BEsN -----END PGP SIGNATURE----- --ffvKqhhpvMLHSEKMG5beu1T8git2pWtRQ--