From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoefL-0002MP-C1 for qemu-devel@nongnu.org; Wed, 12 Nov 2014 15:37:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoefG-0005EM-Cc for qemu-devel@nongnu.org; Wed, 12 Nov 2014 15:37:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoefG-0005D8-4o for qemu-devel@nongnu.org; Wed, 12 Nov 2014 15:37:18 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sACKbGeA019308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 12 Nov 2014 15:37:17 -0500 Message-ID: <5463C4FB.1080506@redhat.com> Date: Wed, 12 Nov 2014 13:37:15 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415808678-30795-1-git-send-email-kwolf@redhat.com> <1415808678-30795-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1415808678-30795-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hxRknwenf7bXIaViBWeklQJ9i67ksCArg" Subject: Re: [Qemu-devel] [PATCH v2 1/5] block/qapi: Add cache information to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hxRknwenf7bXIaViBWeklQJ9i67ksCArg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/12/2014 09:11 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/qapi.c | 7 +++++++ > hmp.c | 8 ++++++++ > qapi/block-core.json | 20 +++++++++++++++++++- > tests/qemu-iotests/051.out | 1 + > tests/qemu-iotests/067.out | 10 +++++----- > 5 files changed, 40 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake > +++ b/tests/qemu-iotests/067.out > @@ -6,7 +6,7 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134= 217728 > Testing: -drive file=3DTEST_DIR/t.qcow2,format=3Dqcow2,if=3Dnone,id=3D= disk -device virtio-blk-pci,drive=3Ddisk,id=3Dvirtio0 > QMP_VERSION > {"return": {}} > -{"return": [{"io-status": "ok", "device": "disk", "locked": false, "re= movable": false, "inserted": {"iops_rd": 0, "detect_zeroes": "off", "imag= e": {"virtual-size": 134217728, "filename": "TEST_DIR/t.qcow2", "cluster-= size": 65536, "format": "qcow2", "actual-size": SIZE, "format-specific": = {"type": "qcow2", "data": {"compat": "1.1", "lazy-refcounts": false, "cor= rupt": false}}, "dirty-flag": false}, "iops_wr": 0, "ro": false, "backing= _file_depth": 0, "drv": "qcow2", "iops": 0, "bps_wr": 0, "encrypted": fal= se, "bps": 0, "bps_rd": 0, "file": "TEST_DIR/t.qcow2", "encryption_key_mi= ssing": false}, "type": "unknown"}, {"io-status": "ok", "device": "ide1-c= d0", "locked": false, "removable": true, "tray_open": false, "type": "unk= nown"}, {"device": "floppy0", "locked": false, "removable": true, "tray_o= pen": false, "type": "unknown"}, {"device": "sd0", "locked": false, "remo= vable": true, "tray_open": false, "type": "unknown"}]} > +{"return": [{"io-status": "ok", "device": "disk", "locked": false, "re= movable": false, "inserted": {"iops_rd": 0, "detect_zeroes": "off", "imag= e": {"virtual-size": 134217728, "filename": "TEST_DIR/t.qcow2", "cluster-= size": 65536, "format": "qcow2", "actual-size": SIZE, "format-specific": = {"type": "qcow2", "data": {"compat": "1.1", "lazy-refcounts": false, "cor= rupt": false}}, "dirty-flag": false}, "iops_wr": 0, "ro": false, "backing= _file_depth": 0, "drv": "qcow2", "iops": 0, "bps_wr": 0, "encrypted": fal= se, "bps": 0, "bps_rd": 0, "cache": {"no-flush": false, "direct": false, = "writeback": true}, "file": "TEST_DIR/t.qcow2", "encryption_key_missing":= false}, "type": "unknown"}, {"io-status": "ok", "device": "ide1-cd0", "l= ocked": false, "removable": true, "tray_open": false, "type": "unknown"},= {"device": "floppy0", "locked": false, "removable": true, "tray_open": f= alse, "type": "unknown"}, {"device": "sd0", "locked": false, "removable":= true, "tray_open": false, "type": "unknow! Will conflict with the patch to add -qmp-pretty to avoid the long lines; but the resolution is straightforward for whoever loses the race. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hxRknwenf7bXIaViBWeklQJ9i67ksCArg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUY8T7AAoJEKeha0olJ0NqKJEIAJU0u344xTGsYeBrdZmj1r4d kI9qgIMt6GWTgCiHyi0kD3mxlYltoto4hMrY7CxPGca7/4uKDvRfuP9GU8tM1sC2 nwLIZkfco9FDgYJfpB0Jt5Tiu7SlNvk/dlIzDsEKQHlnrdNCXyZvI/S5peEv7ged wxIHmMIYmJsfhKrdWbNGGHxvaQqrn8yuMhp6UkuKUsMpmHXtpA8+/SNH2v/xaX0v Xc4NT4NoJGoiB4HTl8izCagph2bHR8dUrNSFvfkAejANOafLXWawtQaT2Y461QvF lrb+B9vbiyHOjLAmO//wiBQDtZmmqYGaVAYz9HhtklswxU0SGGEUqwqbC583cH0= =7gud -----END PGP SIGNATURE----- --hxRknwenf7bXIaViBWeklQJ9i67ksCArg--