From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XogBP-0001jQ-KP for qemu-devel@nongnu.org; Wed, 12 Nov 2014 17:14:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XogBJ-0005Nr-FV for qemu-devel@nongnu.org; Wed, 12 Nov 2014 17:14:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XogBJ-0005Nc-7o for qemu-devel@nongnu.org; Wed, 12 Nov 2014 17:14:29 -0500 Message-ID: <5463DBBA.1000802@redhat.com> Date: Wed, 12 Nov 2014 23:14:18 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415820422-17796-1-git-send-email-armbru@redhat.com> In-Reply-To: <1415820422-17796-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] raw-posix: Get rid of FIEMAP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, tony@bakeyournoodle.com, stefanha@redhat.com, mreitz@redhat.com On 12/11/2014 20:27, Markus Armbruster wrote: > See PATCH 2/2 for rationale. > > Would you like this included in 2.2? > > Markus Armbruster (2): > raw-posix: Fix comment for raw_co_get_block_status() > raw-posix: SEEK_HOLE suffices, get rid of FIEMAP > > block/raw-posix.c | 132 ++++++++++++++++++++---------------------------------- > 1 file changed, 48 insertions(+), 84 deletions(-) > Reviewed-by: Paolo Bonzini though I'm not sure (and for once _I_ can say this to you :)) why you did a bigger change than just removing the call to try_fiemap and the definition of the function. Paolo