From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XogLn-000561-EH for qemu-devel@nongnu.org; Wed, 12 Nov 2014 17:25:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XogLh-0001So-PJ for qemu-devel@nongnu.org; Wed, 12 Nov 2014 17:25:19 -0500 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:59820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XogLh-0001Sk-HZ for qemu-devel@nongnu.org; Wed, 12 Nov 2014 17:25:13 -0500 Received: by mail-wi0-f174.google.com with SMTP id d1so6439212wiv.13 for ; Wed, 12 Nov 2014 14:25:12 -0800 (PST) Sender: Paolo Bonzini Message-ID: <5463DE45.1090901@redhat.com> Date: Wed, 12 Nov 2014 23:25:09 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415812130-2592-1-git-send-email-armbru@redhat.com> <1415812130-2592-5-git-send-email-armbru@redhat.com> <54639572.9020206@suse.de> In-Reply-To: <54639572.9020206@suse.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 4/4] Revert "qom: Add automatic arrayification to object_property_add()" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Markus Armbruster , qemu-devel@nongnu.org Cc: peter.crosthwaite@xilinx.com On 12/11/2014 18:14, Andreas Färber wrote: >> > This reverts commit 339659041f87a76f8b71ad3d12cadfc5f89b4bb3. >> > >> > It's been replaced by object_gen_new_property_name(). >> > >> > Signed-off-by: Markus Armbruster >> > --- >> > qom/object.c | 21 --------------------- >> > 1 file changed, 21 deletions(-) > Acked-by: Andreas Färber > > I believe the sole purpose was to share code between memory and gpio > here. The plan was to move [*] down into the devices. Devices that do not need to arrayify properties (e.g. most qdev-ified devices) can then skip the [*] and have nicer names. Paolo