From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, tony@bakeyournoodle.com,
stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] raw-posix: Fix comment for raw_co_get_block_status()
Date: Wed, 12 Nov 2014 17:18:48 -0600 [thread overview]
Message-ID: <5463EAD8.6040106@redhat.com> (raw)
In-Reply-To: <1415820422-17796-2-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
On 11/12/2014 01:27 PM, Markus Armbruster wrote:
> Missed in commit 705be72.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> block/raw-posix.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index e100ae2..706d3c0 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -1555,9 +1555,7 @@ static int try_seek_hole(BlockDriverState *bs, off_t start, off_t *data,
> }
>
> /*
> - * Returns true iff the specified sector is present in the disk image. Drivers
> - * not implementing the functionality are assumed to not support backing files,
> - * hence all their sectors are reported as allocated.
> + * Returns the allocation status of the specified sectors.
> *
> * If 'sector_num' is beyond the end of the disk image the return value is 0
> * and 'pnum' is set to 0.
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-13 3:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 19:27 [Qemu-devel] [PATCH 0/2] raw-posix: Get rid of FIEMAP Markus Armbruster
2014-11-12 19:27 ` [Qemu-devel] [PATCH 1/2] raw-posix: Fix comment for raw_co_get_block_status() Markus Armbruster
2014-11-12 23:18 ` Eric Blake [this message]
2014-11-13 1:46 ` Fam Zheng
2014-11-13 8:39 ` Max Reitz
2014-11-12 19:27 ` [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP Markus Armbruster
2014-11-12 23:25 ` Eric Blake
2014-11-13 8:53 ` Markus Armbruster
2014-11-13 11:40 ` Kevin Wolf
2014-11-13 11:45 ` Max Reitz
2014-11-13 12:00 ` Kevin Wolf
2014-11-13 12:05 ` Max Reitz
2014-11-13 12:38 ` Markus Armbruster
2014-11-13 13:10 ` Kevin Wolf
2014-11-13 2:21 ` Fam Zheng
2014-11-13 8:26 ` Markus Armbruster
2014-11-13 8:39 ` Max Reitz
2014-11-13 9:25 ` Markus Armbruster
2014-11-12 22:14 ` [Qemu-devel] [PATCH 0/2] raw-posix: Get " Paolo Bonzini
2014-11-13 8:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5463EAD8.6040106@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).