Re: [Qemu-devel] [RFC PATCH] target-ppc: explicitly save page table headers in big endian

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 11/04/2014 02:10 AM, Alexander Graf wrote:
> 
> 
> On 03.11.14 15:56, Cedric Le Goater wrote:
>> On 11/03/2014 03:53 PM, Alexander Graf wrote:
>>>
>>>
>>> On 27.10.14 11:23, Cédric Le Goater wrote:
>>>> Currently, when the page tables are saved, the kvm_get_htab_header structs 
>>>> and the ptes are assumed being big endian and dumped as a indistinct blob 
>>>> in the statefile. This is no longer true when the host is little endian 
>>>> and this breaks restoration.
>>>>
>>>> This patch unfolds the kvmppc_save_htab routine to write explicitly the 
>>>> kvm_get_htab_header structs in big endian. The ptes are left untouched.
>>>>
>>>> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
>>>> Cc: paulus@samba.org
>>>> Cc: aik@ozlabs.ru
>>>> Cc: gkurz@linux.vnet.ibm.com
>>>
>>> LGTM :)
>>
>> OK then. I will resend as a PATCH, along with the kvm kernel patch which is 
>> just a couple of lines. Then, we can start testing cross-endian migration !
> 
> Awesome! Looking forward to it :).

I feel uncomfortable when I see native endian interface. I'd do the whole
kvm_get_htab_header/etc thing BE rather than native but may be it is just me :)



-- 
Alexey