From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xoo7u-0007yl-Ts for qemu-devel@nongnu.org; Thu, 13 Nov 2014 01:43:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xoo7p-0006fB-FA for qemu-devel@nongnu.org; Thu, 13 Nov 2014 01:43:30 -0500 Received: from mail-pd0-f182.google.com ([209.85.192.182]:43573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xoo7p-0006f3-96 for qemu-devel@nongnu.org; Thu, 13 Nov 2014 01:43:25 -0500 Received: by mail-pd0-f182.google.com with SMTP id fp1so13920527pdb.27 for ; Wed, 12 Nov 2014 22:43:23 -0800 (PST) Message-ID: <54645302.6010908@ozlabs.ru> Date: Thu, 13 Nov 2014 17:43:14 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1414405406-653-1-git-send-email-clg@fr.ibm.com> <545796CE.2010706@suse.de> <545797A0.5070602@fr.ibm.com> <54579ACE.3010704@suse.de> In-Reply-To: <54579ACE.3010704@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH] target-ppc: explicitly save page table headers in big endian List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Cedric Le Goater Cc: paulus@samba.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 11/04/2014 02:10 AM, Alexander Graf wrote: > > > On 03.11.14 15:56, Cedric Le Goater wrote: >> On 11/03/2014 03:53 PM, Alexander Graf wrote: >>> >>> >>> On 27.10.14 11:23, Cédric Le Goater wrote: >>>> Currently, when the page tables are saved, the kvm_get_htab_header structs >>>> and the ptes are assumed being big endian and dumped as a indistinct blob >>>> in the statefile. This is no longer true when the host is little endian >>>> and this breaks restoration. >>>> >>>> This patch unfolds the kvmppc_save_htab routine to write explicitly the >>>> kvm_get_htab_header structs in big endian. The ptes are left untouched. >>>> >>>> Signed-off-by: Cédric Le Goater >>>> Cc: paulus@samba.org >>>> Cc: aik@ozlabs.ru >>>> Cc: gkurz@linux.vnet.ibm.com >>> >>> LGTM :) >> >> OK then. I will resend as a PATCH, along with the kvm kernel patch which is >> just a couple of lines. Then, we can start testing cross-endian migration ! > > Awesome! Looking forward to it :). I feel uncomfortable when I see native endian interface. I'd do the whole kvm_get_htab_header/etc thing BE rather than native but may be it is just me :) -- Alexey