From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XorXz-0002gx-JX for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:22:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XorXt-00068h-FL for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:22:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XorXt-00068a-7w for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:22:33 -0500 Message-ID: <54648662.4030709@redhat.com> Date: Thu, 13 Nov 2014 11:22:26 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415873823-13844-1-git-send-email-armbru@redhat.com> <1415873823-13844-4-git-send-email-armbru@redhat.com> In-Reply-To: <1415873823-13844-4-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, tony@bakeyournoodle.com, stefanha@redhat.com, pbonzini@redhat.com On 2014-11-13 at 11:17, Markus Armbruster wrote: > When SEEK_HOLE tells us we're in a hole, we try SEEK_DATA to find its > end. When that fails, we pretend the hole extends to the end of file. > Wrong. Except when SEEK_END fails, we screw up and claim it extends > to offset -1. More wrong. > > Fortunately, these seeks are very unlikely to fail. Fix it anyway, by > returning failure. The caller will then pretend there are no holes. > Inaccurate, but safe. > > Signed-off-by: Markus Armbruster > --- > block/raw-posix.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz