From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XovU1-0005kK-Im for qemu-devel@nongnu.org; Thu, 13 Nov 2014 09:34:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XovTt-0002R0-L7 for qemu-devel@nongnu.org; Thu, 13 Nov 2014 09:34:49 -0500 Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:43592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XovTt-0002Qq-A7 for qemu-devel@nongnu.org; Thu, 13 Nov 2014 09:34:41 -0500 Received: by mail-lb0-f172.google.com with SMTP id u10so3701745lbd.31 for ; Thu, 13 Nov 2014 06:34:40 -0800 (PST) Sender: Paolo Bonzini Message-ID: <5464C17A.2060303@redhat.com> Date: Thu, 13 Nov 2014 15:34:34 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1414661809-21383-1-git-send-email-borntraeger@de.ibm.com> In-Reply-To: <1414661809-21383-1-git-send-email-borntraeger@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/9] valgrind/i386/s390x: memcheck false positives List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Peter Maydell Cc: qemu-devel On 30/10/2014 10:36, Christian Borntraeger wrote: > This series avoids most memcheck false positives in KVM ioctls on s390x > and x86_64. > > Please review and consider for 2.2 or later. Some of these things could > also be fixed in valgrind, but it will take a while until these changes > hit a release or distros. > > The series is also available via signed tag: > > The following changes since commit 3e9418e160cd8901c83a3c88967158084f5b5c03: > > Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM synchronously" (2014-10-27 15:05:09 +0000) > > are available in the git repository at: > > git://github.com/borntraeger/qemu.git tags/memcheck > > for you to fetch changes up to e5bcf96f709e57a54188ffa6a988b6acb603df7a: > > valgrind/s390x: avoid false positives on KVM_SET_FPU ioctl (2014-10-30 10:08:49 +0100) > > ---------------------------------------------------------------- > valgrind/i386/s390x: memcheck false positives > > Let's avoid most memcheck false positives in KVM ioctls. > > ---------------------------------------------------------------- > Christian Borntraeger (9): > valgrind: avoid false positives in KVM_GET_DIRTY_LOG ioctl > valgrind/i386: avoid false positives on KVM_SET_CLOCK ioctl > valgrind/i386: avoid false positives on KVM_SET_PIT ioctl > valgrind/i386: avoid false positives on KVM_SET_XCRS ioctl > valgrind/i386: avoid false positives on KVM_SET_MSRS ioctl > valgrind/i386: avoid false positives on KVM_SET_MSRS(TSC) ioctl > valgrind/i386: avoid false positives on KVM_GET_MSRS ioctl > valgrind/i386: avoid false positives on KVM_SET_VCPU_EVENTS ioctl > valgrind/s390x: avoid false positives on KVM_SET_FPU ioctl > > hw/i386/kvm/clock.c | 3 +-- > hw/i386/kvm/i8254.c | 2 +- > kvm-all.c | 2 +- > target-i386/kvm.c | 9 +++++---- > target-s390x/kvm.c | 2 +- > 5 files changed, 9 insertions(+), 9 deletions(-) > > > Christian, when you respin can you add another one in kvm_irqchip_add_adapter_route? Coverity reports kroute.pad as uninitialized. Paolo