From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, tony@bakeyournoodle.com
Subject: Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure
Date: Thu, 13 Nov 2014 08:52:05 -0700 [thread overview]
Message-ID: <5464D3A5.1030105@redhat.com> (raw)
In-Reply-To: <5464D2FE.8090000@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On 11/13/2014 08:49 AM, Eric Blake wrote:
> On 11/13/2014 08:44 AM, Max Reitz wrote:
>
>>> (By the way, I really wish Solaris had implemented a variant that
>>> queried, but did NOT change the file offset - maybe Linux can add that
>>> as an extension, and give it sane semantics of not special casing
>>> trailing holes...)
>>
>> Are you asking for fiemap? :-P
>
> Not that bulky; maybe just two more constants SEEK_PEEK_HOLE and
> SEEK_PEEK_DATA, which return the same values as their non-peek
> counterparts but without modifying the fd offset.
And not the first time I've requested it. From 2011:
https://lkml.org/lkml/2011/4/22/91
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-13 15:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 10:16 [Qemu-devel] [PATCH v2 0/4] raw-posix: Get rid of FIEMAP, and more Markus Armbruster
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 1/4] raw-posix: Fix comment for raw_co_get_block_status() Markus Armbruster
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 2/4] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP Markus Armbruster
2014-11-13 10:19 ` Max Reitz
2014-11-13 14:09 ` Eric Blake
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure Markus Armbruster
2014-11-13 10:22 ` Max Reitz
2014-11-13 13:03 ` Kevin Wolf
2014-11-13 14:52 ` Eric Blake
2014-11-13 15:29 ` Eric Blake
2014-11-13 15:44 ` Max Reitz
2014-11-13 15:49 ` Eric Blake
2014-11-13 15:52 ` Eric Blake [this message]
2014-11-13 15:47 ` Eric Blake
2014-11-13 16:01 ` Eric Blake
2014-11-14 13:12 ` Markus Armbruster
2014-11-15 0:47 ` Eric Blake
2014-11-13 10:17 ` [Qemu-devel] [PATCH v2 4/4] raw-posix: Clean up around raw_co_get_block_status() Markus Armbruster
2014-11-13 10:27 ` Max Reitz
2014-11-13 12:48 ` Markus Armbruster
2014-11-13 13:30 ` [Qemu-devel] [PATCH v2 0/4] raw-posix: Get rid of FIEMAP, and more Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5464D3A5.1030105@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).