From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xowgw-00079m-JI for qemu-devel@nongnu.org; Thu, 13 Nov 2014 10:52:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xowgs-0003ej-5x for qemu-devel@nongnu.org; Thu, 13 Nov 2014 10:52:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xowgr-0003eb-Ts for qemu-devel@nongnu.org; Thu, 13 Nov 2014 10:52:10 -0500 Message-ID: <5464D3A5.1030105@redhat.com> Date: Thu, 13 Nov 2014 08:52:05 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415873823-13844-1-git-send-email-armbru@redhat.com> <1415873823-13844-4-git-send-email-armbru@redhat.com> <20141113130327.GD3933@noname.redhat.com> <5464C59A.4000602@redhat.com> <5464CE42.4000809@redhat.com> <5464D1D9.7060700@redhat.com> <5464D2FE.8090000@redhat.com> In-Reply-To: <5464D2FE.8090000@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f3J0VHxWuTd0SgTpqEXBsjdD6XtvLqcLf" Subject: Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Kevin Wolf , Markus Armbruster Cc: pbonzini@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, tony@bakeyournoodle.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --f3J0VHxWuTd0SgTpqEXBsjdD6XtvLqcLf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/13/2014 08:49 AM, Eric Blake wrote: > On 11/13/2014 08:44 AM, Max Reitz wrote: >=20 >>> (By the way, I really wish Solaris had implemented a variant that >>> queried, but did NOT change the file offset - maybe Linux can add tha= t >>> as an extension, and give it sane semantics of not special casing >>> trailing holes...) >> >> Are you asking for fiemap? :-P >=20 > Not that bulky; maybe just two more constants SEEK_PEEK_HOLE and > SEEK_PEEK_DATA, which return the same values as their non-peek > counterparts but without modifying the fd offset. And not the first time I've requested it. From 2011: https://lkml.org/lkml/2011/4/22/91 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --f3J0VHxWuTd0SgTpqEXBsjdD6XtvLqcLf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUZNOlAAoJEKeha0olJ0Nq9TgH/RaP9WsYWsNGUty8aoS2+oH9 ghYXL0XyUOcJifK4iljC3K8SrG5YnL2xflghSFUZvbs7lCEYOX0fRIq61hRdtu/w lVh6qwyk2gTHtR8SNXO/xQKNZVNqfovIcUyJ4ZUuqPBWIACgWY7olBFeiAUs5yYY A896Sq4pAgS/HhF4nY6EOjY8ukE+iqIT9k2mQg+13oqxnGEmAteYNnNWuVEZvf6u Xhg2ArVPWb2V1GgI2n58O7Ea6LJN3ry0VrRJTopNK2uu3CIIyHwuvqY6cVlNKi2t YmytbsaNgc54rHc8vP5wdlyux2ep+ECd0G6fqSiH4y/luuHdDgTxcWrtMnJSTDs= =F+2U -----END PGP SIGNATURE----- --f3J0VHxWuTd0SgTpqEXBsjdD6XtvLqcLf--