From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XoxXF-0007KL-5d
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 11:46:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XoxX6-0004jw-LZ
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 11:46:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46119)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XoxX6-0004jp-6S
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 11:46:08 -0500
Message-ID: <5464D42C.2090806@redhat.com>
Date: Thu, 13 Nov 2014 16:54:20 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1415875021-15248-1-git-send-email-maochuan@linux.vnet.ibm.com>
	<1415875021-15248-5-git-send-email-maochuan@linux.vnet.ibm.com>
In-Reply-To: <1415875021-15248-5-git-send-email-maochuan@linux.vnet.ibm.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 RFC 4/9] qemu-iotests: fix test 039
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mao Chuan Li <maochuan@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Michael Mueller <mimu@linux.vnet.ibm.com>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>

On 2014-11-13 at 11:36, Mao Chuan Li wrote:
> For successful execution of case 039, core dump need be
> disabled. Just running "ulimit -c 0" command is not enough when the
> /proc/sys/kernel/core_pattern indicates to pipe the dump to another
> application. So we must erase the pattern in addition to the ulimit
> command.
>
> Reviewed-by:   Michael Mueller <mimu@linux.vnet.ibm.com>
> Signed-off-by: Mao Chuan Li <maochuan@linux.vnet.ibm.com>
> ---
>   tests/qemu-iotests/039 | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039
> index 84c9167..bb9382a 100755
> --- a/tests/qemu-iotests/039
> +++ b/tests/qemu-iotests/039
> @@ -34,6 +34,7 @@ status=1	# failure is the default!
>   _cleanup()
>   {
>   	_cleanup_test_img
> +    _restore_core_pattern
>   }
>   trap "_cleanup; exit \$status" 0 1 2 3 15
>   
> @@ -41,6 +42,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>   . ./common.rc
>   . ./common.filter
>   
> +_erase_core_pattern
> +
>   _supported_fmt qcow2
>   _supported_proto file
>   _supported_os Linux

Do you really want the user to be root to execute the iotests?

Max