From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xow4w-0001Nv-8t for qemu-devel@nongnu.org; Thu, 13 Nov 2014 10:13:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xow4r-0007XR-PR for qemu-devel@nongnu.org; Thu, 13 Nov 2014 10:12:58 -0500 Received: from mail.uni-paderborn.de ([131.234.142.9]:37986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xow4r-0007XL-I2 for qemu-devel@nongnu.org; Thu, 13 Nov 2014 10:12:53 -0500 Message-ID: <5464D8A6.2010203@mail.uni-paderborn.de> Date: Thu, 13 Nov 2014 16:13:26 +0000 From: Bastian Koppelmann MIME-Version: 1.0 References: <1415723092-4088-1-git-send-email-rth@twiddle.net> <1415723092-4088-5-git-send-email-rth@twiddle.net> In-Reply-To: <1415723092-4088-5-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2.3 4/8] tcg: Introduce tcg_op_buf_count and tcg_op_buf_full List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: aurelien@aurel32.net On 11/11/2014 04:24 PM, Richard Henderson wrote: > The method by which we count the number of ops emitted > is going to change. Abstract that away into some inlines. > > Signed-off-by: Richard Henderson > --- > target-alpha/translate.c | 14 +++++++------- > target-arm/translate-a64.c | 9 +++------ > target-arm/translate.c | 9 +++------ > target-cris/translate.c | 13 +++++-------- > target-i386/translate.c | 9 +++------ > target-lm32/translate.c | 14 +++++--------- > target-m68k/translate.c | 9 +++------ > target-microblaze/translate.c | 20 ++++++++------------ > target-mips/translate.c | 8 +++----- > target-moxie/translate.c | 8 +++----- > target-openrisc/translate.c | 13 +++++-------- > target-ppc/translate.c | 9 +++------ > target-s390x/translate.c | 9 +++------ > target-sh4/translate.c | 8 +++----- > target-sparc/translate.c | 8 +++----- > target-tricore/translate.c | 4 +--- > target-unicore32/translate.c | 9 +++------ > target-xtensa/translate.c | 7 +++---- > tcg/tcg.h | 12 ++++++++++++ > 19 files changed, 79 insertions(+), 113 deletions(-) > Again, I'm quiete happy with that change, since these functions make it really clear what is happening. Reviewed-by: Bastian Koppelmann Cheers, Bastian