From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoyjU-0007sx-IQ for qemu-devel@nongnu.org; Thu, 13 Nov 2014 13:03:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoyjO-0000sQ-EB for qemu-devel@nongnu.org; Thu, 13 Nov 2014 13:03:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoyjO-0000s9-7a for qemu-devel@nongnu.org; Thu, 13 Nov 2014 13:02:54 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sADI2qnT008608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 13 Nov 2014 13:02:53 -0500 Message-ID: <5464F24B.5080505@redhat.com> Date: Thu, 13 Nov 2014 13:02:51 -0500 From: John Snow MIME-Version: 1.0 References: <1415874281-7371-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1415874281-7371-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] ahci: small cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org On 11/13/2014 05:24 AM, Stefan Hajnoczi wrote: > Two small cleanups for QEMU 2.3: > > 1. Avoid DEBUG_AHCI bitrot > 2. Use FIS type constants instead of magic numbers > > See commit descriptions for details. > > Stefan Hajnoczi (2): > ahci: avoid #ifdef DEBUG_AHCI bitrot > ahci: replace SATA FIS type magic numbers with constants > > hw/ide/ahci.c | 24 +++++++++++------------- > hw/ide/ahci.h | 5 ++++- > 2 files changed, 15 insertions(+), 14 deletions(-) > Thanks! Reviewed-by: John Snow