From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to make "-net" less prominent
Date: Fri, 9 Mar 2018 15:41:21 +0100 [thread overview]
Message-ID: <5464ff65-85d4-4537-a603-fd20074d375f@redhat.com> (raw)
In-Reply-To: <1520576005-27647-1-git-send-email-thuth@redhat.com>
On 09/03/2018 07:13, Thomas Huth wrote:
> +
> +@item --nic none
> +Indicate that no network devices should be configured. It is used to override
> +the default configuration (default NIC with @option{--net user} backend) which
the default @option{--nic user} configuration (default model and
user-mode networking backend), which...
> +is activated if no other networking options are provided.
> +
> -qemu-system-i386 -net user,hostfwd=tcp::5555-:23 [...]
> +qemu-system-i386 --device e1000,netdev=n1 --netdev user,id=n1,hostfwd=tcp::5555-:23
I would use --nic here. --device/--netdev is covered by
docs/qdev-device-use.txt, which should be updated separately (it even
has -usbdevice still).
> -qemu -net 'user,guestfwd=tcp:10.0.2.100:1234-cmd:netcat 10.10.1.1 4321'
> +qemu-system-i386 --device e1000,netdev=n1 \
> + --netdev 'user,id=n1,guestfwd=tcp:10.0.2.100:1234-cmd:netcat 10.10.1.1 4321'
Same here.
Single vs. double-dash options is a confusing one and I'm not sure how
to proceed. On one hand single-dash is what everyone uses, on the other
double-dash is a bit more consistent with e.g. qemu-img. But:
1) the command-line of qemu-img is anyway completely different from QEMU's
2) mixing them is the worst of both worlds.
I honestly would use single-dashes, and add a note that double-dash
options are supported as well.
Paolo
next prev parent reply other threads:[~2018-03-09 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 6:13 [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to make "-net" less prominent Thomas Huth
2018-03-09 14:36 ` Eric Blake
2018-03-09 17:41 ` Thomas Huth
2018-03-09 19:00 ` Eric Blake
2018-03-09 22:07 ` Thomas Huth
2018-03-09 22:33 ` Eric Blake
2018-03-09 14:41 ` Paolo Bonzini [this message]
2018-03-09 17:20 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5464ff65-85d4-4537-a603-fd20074d375f@redhat.com \
--to=pbonzini@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).