From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xozk6-0001QD-Ui for qemu-devel@nongnu.org; Thu, 13 Nov 2014 14:07:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xozjz-0004jM-9k for qemu-devel@nongnu.org; Thu, 13 Nov 2014 14:07:42 -0500 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:58463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xozjz-0004hU-1E for qemu-devel@nongnu.org; Thu, 13 Nov 2014 14:07:35 -0500 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Nov 2014 19:07:31 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 518101B0805F for ; Thu, 13 Nov 2014 19:07:39 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sADJ7TuW17432930 for ; Thu, 13 Nov 2014 19:07:29 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sADE4jx4003743 for ; Thu, 13 Nov 2014 09:04:46 -0500 Message-ID: <54650170.50000@de.ibm.com> Date: Thu, 13 Nov 2014 20:07:28 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1414661809-21383-1-git-send-email-borntraeger@de.ibm.com> <5464C17A.2060303@redhat.com> In-Reply-To: <5464C17A.2060303@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/9] valgrind/i386/s390x: memcheck false positives List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Peter Maydell Cc: qemu-devel Am 13.11.2014 um 15:34 schrieb Paolo Bonzini: > On 30/10/2014 10:36, Christian Borntraeger wrote: >> This series avoids most memcheck false positives in KVM ioctls on s390x >> and x86_64. >> >> Please review and consider for 2.2 or later. Some of these things could >> also be fixed in valgrind, but it will take a while until these changes >> hit a release or distros. >> >> The series is also available via signed tag: >> >> The following changes since commit 3e9418e160cd8901c83a3c88967158084f5b5c03: >> >> Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM synchronously" (2014-10-27 15:05:09 +0000) >> >> are available in the git repository at: >> >> git://github.com/borntraeger/qemu.git tags/memcheck >> >> for you to fetch changes up to e5bcf96f709e57a54188ffa6a988b6acb603df7a: >> >> valgrind/s390x: avoid false positives on KVM_SET_FPU ioctl (2014-10-30 10:08:49 +0100) >> >> ---------------------------------------------------------------- >> valgrind/i386/s390x: memcheck false positives >> >> Let's avoid most memcheck false positives in KVM ioctls. >> >> ---------------------------------------------------------------- >> Christian Borntraeger (9): >> valgrind: avoid false positives in KVM_GET_DIRTY_LOG ioctl >> valgrind/i386: avoid false positives on KVM_SET_CLOCK ioctl >> valgrind/i386: avoid false positives on KVM_SET_PIT ioctl >> valgrind/i386: avoid false positives on KVM_SET_XCRS ioctl >> valgrind/i386: avoid false positives on KVM_SET_MSRS ioctl >> valgrind/i386: avoid false positives on KVM_SET_MSRS(TSC) ioctl >> valgrind/i386: avoid false positives on KVM_GET_MSRS ioctl >> valgrind/i386: avoid false positives on KVM_SET_VCPU_EVENTS ioctl >> valgrind/s390x: avoid false positives on KVM_SET_FPU ioctl >> >> hw/i386/kvm/clock.c | 3 +-- >> hw/i386/kvm/i8254.c | 2 +- >> kvm-all.c | 2 +- >> target-i386/kvm.c | 9 +++++---- >> target-s390x/kvm.c | 2 +- >> 5 files changed, 9 insertions(+), 9 deletions(-) >> >> >> > > Christian, when you respin can you add another one in > kvm_irqchip_add_adapter_route? Coverity reports kroute.pad as > uninitialized. OK, will do. It will take probably some more days, but it will happen :-)