From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xozy1-0005zm-0P for qemu-devel@nongnu.org; Thu, 13 Nov 2014 14:22:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xozxw-0000aR-3A for qemu-devel@nongnu.org; Thu, 13 Nov 2014 14:22:04 -0500 Received: from smtp.citrix.com ([66.165.176.89]:33382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xozxv-0000ZZ-VW for qemu-devel@nongnu.org; Thu, 13 Nov 2014 14:22:00 -0500 Message-ID: <546504BA.10506@eu.citrix.com> Date: Thu, 13 Nov 2014 19:21:30 +0000 From: George Dunlap MIME-Version: 1.0 References: <1415900529-10629-1-git-send-email-roger.pau@citrix.com> In-Reply-To: <1415900529-10629-1-git-send-email-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 for-xen-4.5] xen_disk: fix unmapping of persistent grants List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roger Pau Monne , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Konrad Rzeszutek Wilk , Stefan Hajnoczi , Stefano Stabellini On 11/13/2014 05:42 PM, Roger Pau Monne wrote: > This patch fixes two issues with persistent grants and the disk PV backend > (Qdisk): > > - Keep track of memory regions where persistent grants have been mapped > since we need to unmap them as a whole. It is not possible to unmap a > single grant if it has been batch-mapped. A new check has also been added > to make sure persistent grants are only used if the whole mapped region > can be persistently mapped in the batch_maps case. > - Unmap persistent grants before switching to the closed state, so the > frontend can also free them. > > Signed-off-by: Roger Pau Monné > Reported-by: George Dunlap Tested-by: George Dunlap