* [Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here too
@ 2014-11-03 18:51 Maciej W. Rozycki
2014-11-14 9:24 ` Leon Alrae
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2014-11-03 18:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Leon Alrae, Aurelien Jarno
CP1.FIR is read-only in hardware so gdbstub must respect it. We already
respect it for CTC1 instructions, so do it here too.
Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
---
Not much to say about it here. Please apply.
Maciej
qemu-mips-fir.diff
Index: qemu-git-trunk/target-mips/gdbstub.c
===================================================================
--- qemu-git-trunk.orig/target-mips/gdbstub.c 2014-11-02 17:51:33.458968203 +0000
+++ qemu-git-trunk/target-mips/gdbstub.c 2014-11-02 17:51:35.958924223 +0000
@@ -112,7 +112,7 @@ int mips_cpu_gdb_write_register(CPUState
RESTORE_ROUNDING_MODE;
break;
case 71:
- env->active_fpu.fcr0 = tmp;
+ /* FIR is read-only. Ignore writes. */
break;
}
return sizeof(target_ulong);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here too
2014-11-03 18:51 [Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here too Maciej W. Rozycki
@ 2014-11-14 9:24 ` Leon Alrae
0 siblings, 0 replies; 2+ messages in thread
From: Leon Alrae @ 2014-11-14 9:24 UTC (permalink / raw)
To: Maciej W. Rozycki, qemu-devel; +Cc: Aurelien Jarno
On 03/11/2014 18:51, Maciej W. Rozycki wrote:
> CP1.FIR is read-only in hardware so gdbstub must respect it. We already
> respect it for CTC1 instructions, so do it here too.
>
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
> ---
> Not much to say about it here. Please apply.
>
> Maciej
>
> qemu-mips-fir.diff
> Index: qemu-git-trunk/target-mips/gdbstub.c
> ===================================================================
> --- qemu-git-trunk.orig/target-mips/gdbstub.c 2014-11-02 17:51:33.458968203 +0000
> +++ qemu-git-trunk/target-mips/gdbstub.c 2014-11-02 17:51:35.958924223 +0000
> @@ -112,7 +112,7 @@ int mips_cpu_gdb_write_register(CPUState
> RESTORE_ROUNDING_MODE;
> break;
> case 71:
> - env->active_fpu.fcr0 = tmp;
> + /* FIR is read-only. Ignore writes. */
> break;
> }
> return sizeof(target_ulong);
>
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-14 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-03 18:51 [Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here too Maciej W. Rozycki
2014-11-14 9:24 ` Leon Alrae
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).