From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34863)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1XpD7B-00040M-0J
	for qemu-devel@nongnu.org; Fri, 14 Nov 2014 04:24:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1XpD76-00069e-H8
	for qemu-devel@nongnu.org; Fri, 14 Nov 2014 04:24:24 -0500
Received: from mailapp01.imgtec.com ([195.59.15.196]:30525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1XpD76-00068h-53
	for qemu-devel@nongnu.org; Fri, 14 Nov 2014 04:24:20 -0500
Message-ID: <5465CA42.1070305@imgtec.com>
Date: Fri, 14 Nov 2014 09:24:18 +0000
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <alpine.DEB.1.10.1411031848030.2881@tp.orcam.me.uk>
In-Reply-To: <alpine.DEB.1.10.1411031848030.2881@tp.orcam.me.uk>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here
	too
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Maciej W. Rozycki" <macro@codesourcery.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>

On 03/11/2014 18:51, Maciej W. Rozycki wrote:
> CP1.FIR is read-only in hardware so gdbstub must respect it.  We already 
> respect it for CTC1 instructions, so do it here too.
> 
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
> ---
> Not much to say about it here.  Please apply.
> 
>   Maciej
> 
> qemu-mips-fir.diff
> Index: qemu-git-trunk/target-mips/gdbstub.c
> ===================================================================
> --- qemu-git-trunk.orig/target-mips/gdbstub.c	2014-11-02 17:51:33.458968203 +0000
> +++ qemu-git-trunk/target-mips/gdbstub.c	2014-11-02 17:51:35.958924223 +0000
> @@ -112,7 +112,7 @@ int mips_cpu_gdb_write_register(CPUState
>              RESTORE_ROUNDING_MODE;
>              break;
>          case 71:
> -            env->active_fpu.fcr0 = tmp;
> +            /* FIR is read-only.  Ignore writes.  */
>              break;
>          }
>          return sizeof(target_ulong);
> 

Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>