From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XpH7l-0005lg-2d
	for qemu-devel@nongnu.org; Fri, 14 Nov 2014 08:41:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XpH7f-0005M0-Sh
	for qemu-devel@nongnu.org; Fri, 14 Nov 2014 08:41:17 -0500
Received: from mail-wg0-x236.google.com ([2a00:1450:400c:c00::236]:58529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XpH7f-0005Ln-Fk
	for qemu-devel@nongnu.org; Fri, 14 Nov 2014 08:41:11 -0500
Received: by mail-wg0-f54.google.com with SMTP id n12so19771616wgh.41
	for <qemu-devel@nongnu.org>; Fri, 14 Nov 2014 05:41:10 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <54660673.40004@twiddle.net>
Date: Fri, 14 Nov 2014 14:41:07 +0100
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1415898767-20461-1-git-send-email-kbastian@mail.uni-paderborn.de>
In-Reply-To: <1415898767-20461-1-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/4] Add TriCore RCPW, RCRR, RCRW,
	RLC and RCR instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org

On 11/13/2014 06:12 PM, Bastian Koppelmann wrote:
> Hi,
> 
> this patch depends on the previous TriCore patches (https://patchwork.ozlabs.org/patch/405459/) and will hopefully end up in 2.3 QEMU.
> Other than adding the RCPW, RCRR, RCRW, RLC and RCR instructions, it cleans up how ISA versions in the feature bitmask are handled,
> to simplify the checks, when instructions are available.
> 
> Thanks,
> Bastian
> 
> v1 -> v2:
>     - Fixed obvious style errors, given by checkpatch.
> 
> Bastian Koppelmann (4):
>   target-tricore: Make TRICORE_FEATURES implying others.
>   target-tricore: Add instructions of RCPW, RCRR and RCRW opcode format
>   target-tricore: Add instructions of RLC opcode format
>   target-tricore: Add instructions of RCR opcode format

Patches 1-3 get

Reviewed-by: Richard Henderson <rth@twiddle.net>

Patch 4 looks correct, but appears to work too hard.


r~