From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41396)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1XpHtd-0005k4-Et
	for qemu-devel@nongnu.org; Fri, 14 Nov 2014 09:30:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1XpHtY-0003Io-HG
	for qemu-devel@nongnu.org; Fri, 14 Nov 2014 09:30:45 -0500
Received: from mail.uni-paderborn.de ([131.234.142.9]:43097)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1XpHtX-0003Ij-O1
	for qemu-devel@nongnu.org; Fri, 14 Nov 2014 09:30:40 -0500
Message-ID: <54662041.2070700@mail.uni-paderborn.de>
Date: Fri, 14 Nov 2014 15:31:13 +0000
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
MIME-Version: 1.0
References: <1415723092-4088-1-git-send-email-rth@twiddle.net>
	<1415723092-4088-9-git-send-email-rth@twiddle.net>
In-Reply-To: <1415723092-4088-9-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2.3 8/8] tcg: Remove unused opcodes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: aurelien@aurel32.net


On 11/11/2014 04:24 PM, Richard Henderson wrote:
> diff --git a/tci.c b/tci.c
> index 4711ee4..28292b3 100644
> --- a/tci.c
> +++ b/tci.c
> @@ -506,19 +506,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
>           tb_ptr += 2;
>   
>           switch (opc) {
> -        case INDEX_op_end:
> -        case INDEX_op_nop:
> -            break;
> -        case INDEX_op_nop1:
> -        case INDEX_op_nop2:
> -        case INDEX_op_nop3:
> -        case INDEX_op_nopn:
> -        case INDEX_op_discard:
> -            TODO();
> -            break;
> -        case INDEX_op_set_label:
> -            TODO();
> -            break;
Why do you remove the TODO notice for INDEX_op_discard/set_label? Is TCI 
no longer maintained?
>           case INDEX_op_call:
>               t0 = tci_read_ri(&tb_ptr);
>   #if TCG_TARGET_REG_BITS == 32
Other than that,

Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

Cheers,
Bastian