From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpKFO-0004Wd-LI for qemu-devel@nongnu.org; Fri, 14 Nov 2014 12:01:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpKFJ-0002eq-Jp for qemu-devel@nongnu.org; Fri, 14 Nov 2014 12:01:22 -0500 Received: from mail.uni-paderborn.de ([131.234.142.9]:47029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpKFJ-0002cp-5g for qemu-devel@nongnu.org; Fri, 14 Nov 2014 12:01:17 -0500 Message-ID: <5466438C.8070602@mail.uni-paderborn.de> Date: Fri, 14 Nov 2014 18:01:48 +0000 From: Bastian Koppelmann MIME-Version: 1.0 References: <1415723092-4088-1-git-send-email-rth@twiddle.net> <1415723092-4088-2-git-send-email-rth@twiddle.net> In-Reply-To: <1415723092-4088-2-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2.3 1/8] tcg: Move some opcode generation functions out of line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: aurelien@aurel32.net On 11/11/2014 04:24 PM, Richard Henderson wrote: > Some of these functions are really quite large. We have a number of > things that ought to be circularly dependent, but we duplicated code > to break that chain for the inlines. > > This saved 25% of the code size of one of the translators I examined. > > Signed-off-by: Richard Henderson > --- > Makefile.target | 2 +- > tcg/tcg-op.c | 1978 +++++++++++++++++++++++++++++++++++++++++++ > tcg/tcg-op.h | 2488 ++++++++----------------------------------------------- > tcg/tcg.c | 137 --- > tcg/tcg.h | 3 - > 5 files changed, 2339 insertions(+), 2269 deletions(-) > create mode 100644 tcg/tcg-op.c > > Reviewed-by: Bastian Koppelmann Cheers, Bastian