From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpgIM-0002Ce-HC for qemu-devel@nongnu.org; Sat, 15 Nov 2014 11:33:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpgIH-0005jJ-FB for qemu-devel@nongnu.org; Sat, 15 Nov 2014 11:33:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpgIH-0005j8-6r for qemu-devel@nongnu.org; Sat, 15 Nov 2014 11:33:49 -0500 Message-ID: <546778AF.5040108@redhat.com> Date: Sat, 15 Nov 2014 09:00:47 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415970374-16811-1-git-send-email-mreitz@redhat.com> <1415970374-16811-3-git-send-email-mreitz@redhat.com> In-Reply-To: <1415970374-16811-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NGPsa0T7NCdTHDgxKQ5kkhDTowMt8bLiu" Subject: Re: [Qemu-devel] [PATCH v2 02/21] qcow2: Add refcount_width to format-specific info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NGPsa0T7NCdTHDgxKQ5kkhDTowMt8bLiu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/14/2014 06:05 AM, Max Reitz wrote: > Add the bit width of every refcount entry to the format-specific > information. >=20 > In contrast to lazy_refcounts and the corrupt flag, this should be > always emitted, even for compat=3D0.10 although it does not support any= > refcount width other than 16 bits. This is because if a boolean is > optional, one normally assumes it to be false when omitted; but if an > integer is not specified, it is rather difficult to guess its value. >=20 > This new field breaks some test outputs, fix them. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 4 +++- > qapi/block-core.json | 5 ++++- > tests/qemu-iotests/060.out | 1 + > tests/qemu-iotests/065 | 23 +++++++++++++++-------- > tests/qemu-iotests/067.out | 5 +++++ > tests/qemu-iotests/082.out | 7 +++++++ > tests/qemu-iotests/089.out | 2 ++ > 7 files changed, 37 insertions(+), 10 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NGPsa0T7NCdTHDgxKQ5kkhDTowMt8bLiu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUZ3ivAAoJEKeha0olJ0NqgYMH/jH/uZ8bR/XkYTjwjRa3iY64 aC8BnPTcp4BQ1NspV8Rqr4jk0omcfXcotHNl2ZlfyeCVbliefff7bH8zpL66NFGQ LFBipRzc1MlM4vh8wPkXmlbRlxH4SXqrddERNEaGmnb+eilRSXR4gQCocYDiUqls hfp+IvvjWbzTZF+05aG5V+GIiLDpkWG4ZbTrX8I0e8q1JRVljxdiYqoqm+R7Ccow /PBXUaOUc5+gQDSO2hFGlbMiD2R2SLD9GhDUUU/jlHpjIKIKVIYofq81ESFHqxVC LreNmtq+bjEhs6detLCcPAkK6J3ZoLZP0HuSYPTKaxqfixLhIJR4E2CDRMk0lJc= =wpPZ -----END PGP SIGNATURE----- --NGPsa0T7NCdTHDgxKQ5kkhDTowMt8bLiu--