From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpgrM-000071-He for qemu-devel@nongnu.org; Sat, 15 Nov 2014 12:10:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpgrG-0000DK-8R for qemu-devel@nongnu.org; Sat, 15 Nov 2014 12:10:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpgrF-0000D5-WD for qemu-devel@nongnu.org; Sat, 15 Nov 2014 12:09:58 -0500 Message-ID: <546788E0.6030008@redhat.com> Date: Sat, 15 Nov 2014 10:09:52 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415970374-16811-1-git-send-email-mreitz@redhat.com> <1415970374-16811-10-git-send-email-mreitz@redhat.com> In-Reply-To: <1415970374-16811-10-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CU1IJ4APlr3vPHG1hcBcnM0kt1rj8MH7R" Subject: Re: [Qemu-devel] [PATCH v2 09/21] qcow2: Open images with refcount order != 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CU1IJ4APlr3vPHG1hcBcnM0kt1rj8MH7R Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/14/2014 06:06 AM, Max Reitz wrote: > No longer refuse to open images with a different refcount entry width > than 16 bits; only reject images with a refcount width larger than 64 > bits (which is prohibited by the specification). >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/block/qcow2.c b/block/qcow2.c > index d70e927..528d696 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -677,10 +677,10 @@ static int qcow2_open(BlockDriverState *bs, QDict= *options, int flags, > } > =20 > /* Check support for various header values */ > - if (header.refcount_order !=3D 4) { > - report_unsupported(bs, errp, "%d bit reference counts", > - 1 << header.refcount_order); > - ret =3D -ENOTSUP; > + if (header.refcount_order > 6) { > + error_setg(errp, "Reference count entry width too large; may n= ot " > + "exceed 64 bit"); s/bit/bits/ Maintainer can make that tweak, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CU1IJ4APlr3vPHG1hcBcnM0kt1rj8MH7R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUZ4jgAAoJEKeha0olJ0Nq0GAH/3sycMEEAcG0CShAfcsnAmkK 68NprS/qsrVld0cVB8UcmWmLN2RswIZHREQrW9/HQsaj9ZKsiUFNLhsUNXkiatw0 NG0yzJ4el7OyjrtmP2f8Bf3Zowm9g/g7J0VoXfuOTDpQ5FUtwWszyPllVIb/HlgZ XSz+zIo4B04V5JyrfWynVCyU7RMG8FO/vRhPTt5hhw7lYcdizST8iki0myHc22ej GbfsQJbhOokZ9rbp4LDY4MoS8sLx0WQ5B3vmxkeEW/Cs44OH2b7PCJL/s6QuUjlX evPLNO54FurtkTk1hCaFwoHgc5L3O57OuM9P3x7vMPDvanH13SUG5B/xvNKvtEg= =wMF3 -----END PGP SIGNATURE----- --CU1IJ4APlr3vPHG1hcBcnM0kt1rj8MH7R--