From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpgz1-0003l3-Gj for qemu-devel@nongnu.org; Sat, 15 Nov 2014 12:18:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xpgyw-0003PL-Ig for qemu-devel@nongnu.org; Sat, 15 Nov 2014 12:17:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xpgyw-0003P8-A3 for qemu-devel@nongnu.org; Sat, 15 Nov 2014 12:17:54 -0500 Message-ID: <54678ABD.6060600@redhat.com> Date: Sat, 15 Nov 2014 10:17:49 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415970374-16811-1-git-send-email-mreitz@redhat.com> <1415970374-16811-12-git-send-email-mreitz@redhat.com> In-Reply-To: <1415970374-16811-12-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QDKjbXs0euBvuhpMr09bdGDo1cmc7Tfjc" Subject: Re: [Qemu-devel] [PATCH v2 11/21] iotests: Prepare for refcount_width option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QDKjbXs0euBvuhpMr09bdGDo1cmc7Tfjc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/14/2014 06:06 AM, Max Reitz wrote: > Some tests do not work well with certain refcount widths (i.e. you > cannot create internal snapshots with refcount_width=3D1), so make thos= e > widths unsupported. >=20 > Furthermore, add another filter to _filter_img_create in common.filter > which filters out the refcount_width value. >=20 > This is necessary for test 079, which does actually work with any > refcount width, but invoking qemu-img directly leads to the > refcount_width value being visible in the output; use _make_test_img > instead which will filter it out. >=20 > Signed-off-by: Max Reitz > --- > +++ b/tests/qemu-iotests/029 > @@ -44,6 +44,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > _supported_fmt qcow2 > _supported_proto generic > _supported_os Linux > +_unsupported_imgopts 'refcount_width=3D1[^0-9]' Missed a comment here. > +++ b/tests/qemu-iotests/common.filter > @@ -190,7 +190,8 @@ _filter_img_create() > -e "s# block_size=3D[0-9]\\+##g" \ > -e "s# block_state_zero=3D\\(on\\|off\\)##g" \ > -e "s# log_size=3D[0-9]\\+##g" \ > - -e "s/archipelago:a/TEST_DIR\//g" > + -e "s/archipelago:a/TEST_DIR\//g" \ > + -e "s# refcount_width=3D[0-9]\\+##g" I'm not convinced that \+ is portable sed; but as you are not the first use, it's not worth changing. Once you add the remaining comment, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QDKjbXs0euBvuhpMr09bdGDo1cmc7Tfjc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUZ4q9AAoJEKeha0olJ0Nqft8IAK1vujF/B7TncXiOM3U5s/Fj gW+pvUItg/eYG1AJSR+VgS2mluU7bVEUQHHBN5umu1FqW7MZk98MzzRgiKyk+yCO z32iNFRKs02xlYa3Nh6f+7klOOYBeT6MKRClfMCx3bMn/wPQu2cQo0KeFejQ+pOs lqLEPs0uSXLAPFAUWbhsweORllpKz53VagNtekHhDFns3RgpXdgp8cxIrK6HicwD Pxaj2H2Mce4SCDkanMr7EMZf3JFO6PS4xOjNBCGMpC1SRmPKvUnUKhRrBMEm5Opz giA0hgf0s3w/aGpVaEpxukfi5/1I/CkBUXEDm+WLRL3bVgRZg/w5xFXjoLOX56s= =YwJx -----END PGP SIGNATURE----- --QDKjbXs0euBvuhpMr09bdGDo1cmc7Tfjc--