From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48956)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XqK2W-0006vd-Er
	for qemu-devel@nongnu.org; Mon, 17 Nov 2014 06:00:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XqK2R-00085i-Ke
	for qemu-devel@nongnu.org; Mon, 17 Nov 2014 06:00:12 -0500
Message-ID: <5469D51A.9010703@redhat.com>
Date: Mon, 17 Nov 2014 11:59:38 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1416203854-11908-1-git-send-email-zhang.zhanghailiang@huawei.com>
In-Reply-To: <1416203854-11908-1-git-send-email-zhang.zhanghailiang@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-cris/translate.c: fix out of bounds
	read
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-trivial@nongnu.org
Cc: edgar.iglesias@gmail.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com

On 17/11/2014 06:57, zhanghailiang wrote:
> In function t_gen_mov_TN_preg and t_gen_mov_preg_TN, The begin check about the
> validity of in-parameter 'r' is useless. We still access cpu_PR[r] in the
> follow code if it is invalid. Which will be an out-of-bounds read error.
> 
> Fix it by using assert() to ensure it is valid before using it.
> 
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
>  target-cris/translate.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/target-cris/translate.c b/target-cris/translate.c
> index e37b04e..76406af 100644
> --- a/target-cris/translate.c
> +++ b/target-cris/translate.c
> @@ -169,9 +169,7 @@ static int preg_sizes[] = {
>  
>  static inline void t_gen_mov_TN_preg(TCGv tn, int r)
>  {
> -    if (r < 0 || r > 15) {
> -        fprintf(stderr, "wrong register read $p%d\n", r);
> -    }
> +    assert(r >= 0 && r <= 15);
>      if (r == PR_BZ || r == PR_WZ || r == PR_DZ) {
>          tcg_gen_mov_tl(tn, tcg_const_tl(0));
>      } else if (r == PR_VR) {
> @@ -182,9 +180,7 @@ static inline void t_gen_mov_TN_preg(TCGv tn, int r)
>  }
>  static inline void t_gen_mov_preg_TN(DisasContext *dc, int r, TCGv tn)
>  {
> -    if (r < 0 || r > 15) {
> -        fprintf(stderr, "wrong register write $p%d\n", r);
> -    }
> +    assert(r >= 0 && r <= 15);
>      if (r == PR_BZ || r == PR_WZ || r == PR_DZ) {
>          return;
>      } else if (r == PR_SRS) {
> 

Applied, thanks.

Paolo