From: Thomas Huth <thuth@redhat.com>
To: "Roman Kiryanov" <rkir@google.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: "Felix Wu" <flwu@google.com>,
qemu-devel@nongnu.org, peter.maydell@linaro.org,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH 1/1] include/qemu: Provide a C++ compatible version of typeof_strip_qual
Date: Tue, 25 Jun 2024 08:07:15 +0200 [thread overview]
Message-ID: <5469fc13-7c64-4c10-8b48-34814b529b82@redhat.com> (raw)
In-Reply-To: <CAOGAQeq0b3_g80k5xa-6f+XPkv6C=nfMLkJt=X3-6FD_d3sJUA@mail.gmail.com>
On 25/06/2024 04.32, Roman Kiryanov wrote:
> Hi Philippe, thank you for looking.
>
> On Mon, Jun 24, 2024 at 7:27 PM Philippe Mathieu-Daudé
> <philmd@linaro.org> wrote:
>> In particular this patch seems contained well enough
>> to be carried in forks were C++ _is_ used.
>
> Will you agree to take #ifdef __cplusplus and #error to the QEMU side
> in atomic.h and
> we will keep atomic.hpp on our side?
Well, from an upstream QEMU perspective, it doesn't make sense to have an
#error with a message that references a file that does not exist in the
upstream repository, so I think that patch also rather belongs to your
C++-enabled downstream repository.
Thomas
next prev parent reply other threads:[~2024-06-25 6:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 20:56 [PATCH 1/1] include/qemu: Provide a C++ compatible version of typeof_strip_qual Felix Wu
2024-06-25 2:26 ` Philippe Mathieu-Daudé
2024-06-25 2:32 ` Roman Kiryanov
2024-06-25 6:05 ` Paolo Bonzini
2024-06-25 6:19 ` Philippe Mathieu-Daudé
2024-06-25 9:27 ` Peter Maydell
2024-06-25 10:16 ` Peter Maydell
2024-06-25 10:31 ` Daniel P. Berrangé
2024-06-25 6:07 ` Thomas Huth [this message]
2024-06-25 7:52 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5469fc13-7c64-4c10-8b48-34814b529b82@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=flwu@google.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).