From: Leon Alrae <leon.alrae@imgtec.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] mips: Correct the writes to CP0 Status and Cause registers via gdbstub
Date: Mon, 17 Nov 2014 14:32:18 +0000 [thread overview]
Message-ID: <546A06F2.5090408@imgtec.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1411100008240.2881@tp.orcam.me.uk>
Hi Maciej,
On 10/11/2014 13:46, Maciej W. Rozycki wrote:
> qemu-mips-status.diff
> Index: qemu-git-trunk/target-mips/cpu.h
> ===================================================================
> --- qemu-git-trunk.orig/target-mips/cpu.h 2014-11-09 23:44:32.000000000 +0000
> +++ qemu-git-trunk/target-mips/cpu.h 2014-11-09 23:49:54.997846651 +0000
Could you please include diffstat when you generate patches? (git
format-patch adds it by default). It makes review much easier -
especially of longer patches - as it immediately tells which files and
how many lines have been modified before starting looking at the actual
changes.
Thanks,
Leon
prev parent reply other threads:[~2014-11-17 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 13:46 [Qemu-devel] [PATCH] mips: Correct the writes to CP0 Status and Cause registers via gdbstub Maciej W. Rozycki
2014-11-17 14:32 ` Leon Alrae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546A06F2.5090408@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=macro@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).