From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqPCt-0008TD-C3 for qemu-devel@nongnu.org; Mon, 17 Nov 2014 11:31:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqPCo-0000zb-FT for qemu-devel@nongnu.org; Mon, 17 Nov 2014 11:31:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqPCo-0000ya-8v for qemu-devel@nongnu.org; Mon, 17 Nov 2014 11:31:10 -0500 Message-ID: <546A22C6.5000307@redhat.com> Date: Mon, 17 Nov 2014 09:31:02 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416219514-22530-1-git-send-email-armbru@redhat.com> <1416219514-22530-3-git-send-email-armbru@redhat.com> <5469CE54.3010607@redhat.com> <87k32uf5zs.fsf@blackfin.pond.sub.org> In-Reply-To: <87k32uf5zs.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="COj4MMP3gRxU1vJUCU1GleNhE0guEIO1b" Subject: Re: [Qemu-devel] [PATCH v3 for-2.2 2/3] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Max Reitz Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, tony@bakeyournoodle.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --COj4MMP3gRxU1vJUCU1GleNhE0guEIO1b Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/17/2014 03:58 AM, Markus Armbruster wrote: > Max Reitz writes: >=20 >> On 2014-11-17 at 11:18, Markus Armbruster wrote: >>> Commit 5500316 (May 2012) implemented raw_co_is_allocated() as >>> follows: >>> >>> Signed-off-by: Markus Armbruster >>> Reviewed-by: Max Reitz >>> Reviewed-by: Eric Blake >>> --- >>> block/raw-posix.c | 60 ++++----------------------------------------= ----------- >>> 1 file changed, 4 insertions(+), 56 deletions(-) >> >> I only just now realized that you're not getting rid of FIEMAP >> completely; there's still the skip_fiemap flag in BDRVRawState. I >> don't care for now, though, thus my R-b stands. >=20 > You're right! The appended patch should be squashed in, either on > commit, or in a respin. My R-b stands whether or not you squash this in; best situation would be squashing this in during commit. >=20 >=20 > diff --git a/block/raw-posix.c b/block/raw-posix.c > index 0b5d5a8..414e6d1 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > @@ -148,9 +148,6 @@ typedef struct BDRVRawState { > bool has_write_zeroes:1; > bool discard_zeroes:1; > bool needs_alignment; > -#ifdef CONFIG_FIEMAP > - bool skip_fiemap; > -#endif > } BDRVRawState; > =20 > typedef struct BDRVRawReopenState { >=20 >=20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --COj4MMP3gRxU1vJUCU1GleNhE0guEIO1b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUaiLGAAoJEKeha0olJ0Nqa7wH/j1UkevDwF30Rd03bakmh3W2 tlmV9lZOynEER6zUEuwyQLGYvycd2eNzjmzHjqnKOdYWiohQlgKvcqzxpQ8qegQB z5Y/SFHJHMi8EImjNzGaq5tfnECab1ZwE6boA+s68ltFP6CFp79jkw/Az7Yf5V0w 0nf+IuzBrdD+loSI4IQdu0tBB7bMtyY703Wfmuv5/RanbvATxboT+tDeDqGxrOWI lfoUeoAR39V4wq3/bBDy4LqGYXEMypgrESSZKkNHu34Ry2xhq/WuaQ7w3/3Oe06T luBexvkmjytLDt1L/4RSKc42Ox19D9GJAAOfxHwE3pvAF/z/0X+VocSs1w8lsrU= =EYln -----END PGP SIGNATURE----- --COj4MMP3gRxU1vJUCU1GleNhE0guEIO1b--