From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqeTA-0006nH-0o for qemu-devel@nongnu.org; Tue, 18 Nov 2014 03:49:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqeT5-0002T7-6Z for qemu-devel@nongnu.org; Tue, 18 Nov 2014 03:49:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqeT4-0002Sx-TF for qemu-devel@nongnu.org; Tue, 18 Nov 2014 03:48:59 -0500 Message-ID: <546B07F2.9040709@redhat.com> Date: Tue, 18 Nov 2014 09:48:50 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416219514-22530-1-git-send-email-armbru@redhat.com> In-Reply-To: <1416219514-22530-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 for-2.2 0/3] raw-posix: Get rid of FIEMAP, fix SEEK_HOLE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, tony@bakeyournoodle.com, stefanha@redhat.com, pbonzini@redhat.com On 2014-11-17 at 11:18, Markus Armbruster wrote: > PATCH 1 is just a comment fix. PATCH 2 drops FIEMAP use and explains > why it needs to go. PATCH 3 carefully rewrites the SEEK_HOLE code. > > Why 2.2? The series fixes bugs, but the bugs are either not terribly > severe, or not particularly likely to bite. The reason I want it > included is we've already changed the code fundamentally in 2.2, from > > Incorrect use of FIEMAP if available, else somewhat incorrect use > of SEEK_HOLE if available, else pretend no holes > > to > > Somewhat incorrect use of SEEK_HOLE if available, else correct but > slow-as-molasses use of FIEMAP if available, else pretend no holes > > Let's finish the job: > > Correct use of SEEK_HOLE if available, else pretend no holes > > Less complex, more robust, and no half-broken intermediate version > released. > > v3: > * PATCH 1&2 unchanged, except for a commit message typo [Eric] > * PATCH 3&4 redone as PATCH 3, very carefully [Eric, Kevin] > > v2: > * PATCH 1 unchanged > * PATCH 2 revised and split up [Paolo, Fam, Eric, Max] > > Markus Armbruster (3): > raw-posix: Fix comment for raw_co_get_block_status() > raw-posix: SEEK_HOLE suffices, get rid of FIEMAP > raw-posix: The SEEK_HOLE code is flawed, rewrite it > > block/raw-posix.c | 167 ++++++++++++++++++++++++++++-------------------------- > 1 file changed, 86 insertions(+), 81 deletions(-) Thanks, applied to my block tree with the hunk removing skip_fiemap squashed into patch 2: https://github.com/XanClic/qemu/commits/block