From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xqf9U-0005x9-Af for qemu-devel@nongnu.org; Tue, 18 Nov 2014 04:32:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xqf9N-0001Ot-TI for qemu-devel@nongnu.org; Tue, 18 Nov 2014 04:32:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xqf9N-0001Oj-L2 for qemu-devel@nongnu.org; Tue, 18 Nov 2014 04:32:41 -0500 Message-ID: <546B1231.90406@redhat.com> Date: Tue, 18 Nov 2014 10:32:33 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416238250-414-1-git-send-email-mreitz@redhat.com> <1416238250-414-6-git-send-email-mreitz@redhat.com> <546A305E.9040709@redhat.com> In-Reply-To: <546A305E.9040709@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] nbd: Use BlockBackend internally List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Markus Armbruster , Stefan Hajnoczi On 2014-11-17 at 18:29, Paolo Bonzini wrote: > > On 17/11/2014 16:30, Max Reitz wrote: >> With all externally visible functions changed to use BlockBackend, this >> patch makes nbd use BlockBackend for everything internally as well. >> >> While touching them, substitute 512 by BDRV_SECTOR_SIZE in the calls to >> blk_read(), blk_write() and blk_co_discard(). >> >> Signed-off-by: Max Reitz > qemu-nbd.c has more uses of "bs" that probably should be changed to > "blk". Not sure if it should be in this patch, patch 4 or an additional > patch 6 though. Good point. I'll go for patch 6. > If the third possibility, series > > Reviewed-by: Paolo Bonzini Thanks! Max