From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqjQr-0005CZ-L0 for qemu-devel@nongnu.org; Tue, 18 Nov 2014 09:07:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqjQl-0001gv-9m for qemu-devel@nongnu.org; Tue, 18 Nov 2014 09:07:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqjQl-0001gR-38 for qemu-devel@nongnu.org; Tue, 18 Nov 2014 09:06:55 -0500 Message-ID: <546B5270.5080402@redhat.com> Date: Tue, 18 Nov 2014 15:06:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415286601-30715-1-git-send-email-ming.lei@canonical.com> <1415286601-30715-4-git-send-email-ming.lei@canonical.com> In-Reply-To: <1415286601-30715-4-git-send-email-ming.lei@canonical.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ming Lei , qemu-devel@nongnu.org, Peter Maydell , Stefan Hajnoczi , Kevin Wolf Cc: =?windows-1252?Q?Beno=EEt_Canet?= On 06/11/2014 16:10, Ming Lei wrote: > No one uses the 'node' field any more, so remove it > from 'struct qemu_laiocb', and this can save 16byte > for the struct on 64bit arch. > > Signed-off-by: Ming Lei > --- > block/linux-aio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/linux-aio.c b/block/linux-aio.c > index f5ca41d..b12da25 100644 > --- a/block/linux-aio.c > +++ b/block/linux-aio.c > @@ -35,7 +35,6 @@ struct qemu_laiocb { > size_t nbytes; > QEMUIOVector *qiov; > bool is_read; > - QLIST_ENTRY(qemu_laiocb) node; > }; > > /* > Reviewed-by: Paolo Bonzini