From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr0cz-0004yJ-1T for qemu-devel@nongnu.org; Wed, 19 Nov 2014 03:28:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xr0cs-00022g-LC for qemu-devel@nongnu.org; Wed, 19 Nov 2014 03:28:40 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:64700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr0cr-0001xs-Vl for qemu-devel@nongnu.org; Wed, 19 Nov 2014 03:28:34 -0500 Message-ID: <546C5499.1000907@huawei.com> Date: Wed, 19 Nov 2014 16:28:09 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1416201070-11448-1-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1416201070-11448-1-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: imammedo@redhat.com, peter.huangpeng@huawei.com, mst@redhat.com Hi, Ping...? Should this be fixed in 2.2? Thanks, zhanghailiang On 2014/11/17 13:11, zhanghailiang wrote: > Hi, > > Patch 1 and 2 mainly fix bug about balloon not working correctly when we do > hotplug memory. It takes 'ram_size' as VM's real RAM size which is wrong > after we hotplug memory. > > This bug exists since we begin to support hotplug memory, and it is better > to fix it. > > Patch 3 add some trace events, it helps debugging balloon. If it is unnecessary, > pls feel free to remove it. > > Thanks, > zhanghailiang > > v2: > - fix compiling break for other targets that don't support pc-dimm > > zhanghailiang (3): > pc-dimm: add a function to calculate VM's current RAM size > virtio-balloon: Fix balloon not working correctly when hotplug memory > virtio-balloon: Add some trace events > > hw/mem/pc-dimm.c | 26 ++++++++++++++++++++++++++ > hw/virtio/virtio-balloon.c | 21 +++++++++++++++------ > include/exec/cpu-common.h | 1 + > stubs/qmp_pc_dimm_device_list.c | 5 +++++ > trace-events | 4 ++++ > 5 files changed, 51 insertions(+), 6 deletions(-) >