From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr69D-0003oX-Ei for qemu-devel@nongnu.org; Wed, 19 Nov 2014 09:22:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xr697-0005Ik-9v for qemu-devel@nongnu.org; Wed, 19 Nov 2014 09:22:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr697-0005Ic-2t for qemu-devel@nongnu.org; Wed, 19 Nov 2014 09:22:13 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAJEMBk2015186 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 19 Nov 2014 09:22:12 -0500 Message-ID: <546CA78F.2030801@redhat.com> Date: Wed, 19 Nov 2014 15:22:07 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <546AE14E.7060606@redhat.com> <20141118074904.GA19745@redhat.com> <87y4r7o8dh.fsf@elfo.elfo> <20141119093320.GA26119@redhat.com> <87d28jo5yp.fsf@elfo.elfo> <20141119102136.GC26395@redhat.com> <878uj7o4ec.fsf@elfo.elfo> <20141119132851.GA27435@redhat.com> <546C9EC0.5000105@redhat.com> <87ioibmgx6.fsf@elfo.elfo> <20141119141301.GC2355@work-vm> In-Reply-To: <20141119141301.GC2355@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] exec: qemu_ram_alloc_device, qemu_ram_resize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Juan Quintela Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On 19/11/2014 15:13, Dr. David Alan Gilbert wrote: > Since we've wondered off the actual ACPI table stuff into general > ROM sizing, I'd like to propose some concrete fixes: > > 1) We explicitly name the bios file in a .romfile attribute for > all ROMs. > 2) The code that uses .romfile has an expansion for $MACHINETYPE > 3) We actually symlink all of those together, anyone who wants/has > to deal with different versions can downstream. > 4) The machine types contain size attributes for the ROMs that > are generoously larger than the ROMs anyone currently uses. > > I think 1..3 should deal with those of us who have to deal with different > ROM versions on different machine types. It should, but it's a solution in search of a problem. > 4 might be good enough for the ACPI tables if you can bound it. Already doing that (rounding to 128k, warning if >64k), but it is not a definitive solution. We also do (4) for ROMs, since VGA BIOSes use only 36k out of 64k and iPXE ROMs use only ~200k out of 256k. Paolo