From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr9gc-0007MU-1M for qemu-devel@nongnu.org; Wed, 19 Nov 2014 13:09:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xr9gV-0004Hx-T1 for qemu-devel@nongnu.org; Wed, 19 Nov 2014 13:09:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr9gV-0004Ht-L6 for qemu-devel@nongnu.org; Wed, 19 Nov 2014 13:08:55 -0500 Message-ID: <546CDCAD.9030800@redhat.com> Date: Wed, 19 Nov 2014 19:08:45 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1416418257-10166-1-git-send-email-dslutz@verizon.com> <546CD4F1.4040602@redhat.com> <546CDC46.8050603@terremark.com> In-Reply-To: <546CDC46.8050603@terremark.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/i386/pc_piix.c: Also pass vmport=off for xenfv machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Don Slutz , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , Eduardo Habkost Cc: Michael Tokarev , Anthony Liguori , Stefan Hajnoczi On 19/11/2014 19:07, Don Slutz wrote: >>> >> "-M pc -machine accel=xen" should work and, if that's what you want, >> disable the vmport device. I think this patch is wrong. >> >> Paolo > > Well, I also want "-M pc -machine accel=xen,vmport=on" to work. Right. So let's start by deciding what the desired semantics are for all six cases: -M pc/xenfv, -machine vmport=on/off/absent. Paolo > However you bring up a good point and I will see if I can quickly handled it.