From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrJ61-0001dz-8I for qemu-devel@nongnu.org; Wed, 19 Nov 2014 23:11:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrJ5v-0005Ez-0r for qemu-devel@nongnu.org; Wed, 19 Nov 2014 23:11:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrJ5u-0005Ea-OG for qemu-devel@nongnu.org; Wed, 19 Nov 2014 23:11:46 -0500 Message-ID: <546D69FD.2050006@redhat.com> Date: Wed, 19 Nov 2014 21:11:41 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416443890-20263-1-git-send-email-dslutz@verizon.com> In-Reply-To: <1416443890-20263-1-git-send-email-dslutz@verizon.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sk8pXe4XN8XBA3XNHSvitSqb4uT1RdoW7" Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine vmport=auto: Fix handling of VMWare ioport emulation for xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Don Slutz , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost Cc: Michael Tokarev , Anthony Liguori , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sk8pXe4XN8XBA3XNHSvitSqb4uT1RdoW7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/19/2014 05:38 PM, Don Slutz wrote: > c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4 >=20 > or >=20 > c/s b154537ad07598377ebf98252fb7d2aff127983b >=20 > moved the testing of xen_enabled() from pc_init1() to > pc_machine_initfn(). >=20 > xen_enabled() does not return the correct value in > pc_machine_initfn(). >=20 > Changed vmport from a bool to an enum. Added the value "auto" to do > the old way. >=20 > +++ b/qapi-schema.json > @@ -3513,3 +3513,19 @@ > # Since: 2.1 > ## > { 'command': 'rtc-reset-reinjection' } > + > +## > +# @vmport > +# > +# An enumeration of the options on enabling of VMWare ioport emulation= > +# > +# @auto: system selects the old default > +# > +# @on: provide the vmport device > +# > +# @off: do not provide the vmport device > +# > +# Since: 2.2 > +## > +{ 'enum': 'vmport', All other enums in .json files are named in StudlyCaps. Please name this starting with a capital letter, and reserve all-lower-case names for commands and built-in types. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Sk8pXe4XN8XBA3XNHSvitSqb4uT1RdoW7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUbWn9AAoJEKeha0olJ0Nq5S0IAJGoqHzHgyLkbya6rofLuIq/ Q7XL4IZ9T3YvXAe/s61naRxHSynwUsxiB9U2HGuwr9T4yU6nxkTSVywBpsskLKeQ sKquPEdZU6EzWL8tFXKwmO7goFzdNXi5IG0qEuWoTnpXSDSQW4Y4irZ5I0Qqbte5 Ghail3ZL7nfdGdeh6dORRaCsmdDUB+px4n2+kTB3mtETkbi32EEDgpQKyHcyBbqg hlMeNy3kJxXe2lzEsh3tKaXKYEYEmVUvrFVXXdmk+L7VhYhxIsAYbwO6Onn/n3F8 1Ac5stN3GM75+xebO/xEmXn7C5O788Mn0ml8ECv8TKEB+NEaIel8fsS+S+FKrpc= =MwGR -----END PGP SIGNATURE----- --Sk8pXe4XN8XBA3XNHSvitSqb4uT1RdoW7--