From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XrKqj-00055A-PE
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 01:04:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XrKqa-0007LX-OV
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 01:04:13 -0500
Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:54716)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XrKqa-0007LP-IA
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 01:04:04 -0500
Received: by mail-wi0-f179.google.com with SMTP id ex7so4160254wid.12
	for <qemu-devel@nongnu.org>; Wed, 19 Nov 2014 22:04:04 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <546D8450.2080900@redhat.com>
Date: Thu, 20 Nov 2014 07:04:00 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1416443890-20263-1-git-send-email-dslutz@verizon.com>
	<20141120005824.GH3243@thinpad.lan.raisama.net>
In-Reply-To: <20141120005824.GH3243@thinpad.lan.raisama.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine
 vmport=auto: Fix handling of VMWare ioport emulation for xen
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, Don Slutz <dslutz@verizon.com>
Cc: Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>



On 20/11/2014 01:58, Eduardo Habkost wrote:
>     if (pc_machine->vmport == VMPORT_AUTO) {
>           no_vmport = xen_enabled();
>     } else {
>           no_vmport = (pc_machine->vmport == VMPORT_ON);
>     }

I'm still not sure why the configuration should differ for "-M pc"
depending on whether xen is enabled.

Paolo