[Qemu-devel] [PATCH v1 RFC 4/9] qemu-iotests: fix test 039

[Qemu-devel] [PATCH v1 RFC 4/9] qemu-iotests: fix test 039

[Mao Chuan Li]

For successful execution of case 039, core dump need be
disabled. Just running "ulimit -c 0" command is not enough when the
/proc/sys/kernel/core_pattern indicates to pipe the dump to another
application. So we must erase the pattern in addition to the ulimit
command.

Reviewed-by:   Michael Mueller <mimu@linux.vnet.ibm.com>
Signed-off-by: Mao Chuan Li <maochuan@linux.vnet.ibm.com>
---
 tests/qemu-iotests/039 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039
index 84c9167..bb9382a 100755
--- a/tests/qemu-iotests/039
+++ b/tests/qemu-iotests/039
@@ -34,6 +34,7 @@ status=1	# failure is the default!
 _cleanup()
 {
 	_cleanup_test_img
+    _restore_core_pattern
 }
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
@@ -41,6 +42,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 . ./common.rc
 . ./common.filter
 
+_erase_core_pattern
+
 _supported_fmt qcow2
 _supported_proto file
 _supported_os Linux
-- 
1.9.3

Re: [Qemu-devel] [PATCH v1 RFC 4/9] qemu-iotests: fix test 039

[Max Reitz]

On 2014-11-13 at 11:36, Mao Chuan Li wrote:
> For successful execution of case 039, core dump need be
> disabled. Just running "ulimit -c 0" command is not enough when the
> /proc/sys/kernel/core_pattern indicates to pipe the dump to another
> application. So we must erase the pattern in addition to the ulimit
> command.
>
> Reviewed-by:   Michael Mueller <mimu@linux.vnet.ibm.com>
> Signed-off-by: Mao Chuan Li <maochuan@linux.vnet.ibm.com>
> ---
>   tests/qemu-iotests/039 | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039
> index 84c9167..bb9382a 100755
> --- a/tests/qemu-iotests/039
> +++ b/tests/qemu-iotests/039
> @@ -34,6 +34,7 @@ status=1	# failure is the default!
>   _cleanup()
>   {
>   	_cleanup_test_img
> +    _restore_core_pattern
>   }
>   trap "_cleanup; exit \$status" 0 1 2 3 15
>   
> @@ -41,6 +42,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>   . ./common.rc
>   . ./common.filter
>   
> +_erase_core_pattern
> +
>   _supported_fmt qcow2
>   _supported_proto file
>   _supported_os Linux

Do you really want the user to be root to execute the iotests?

Max

Re: [Qemu-devel] [PATCH v1 RFC 4/9] qemu-iotests: fix test 039

[Max Reitz]

On 2014-11-20 at 09:08, Mao Chuan Li wrote:
> The intention is to disable the core dump, if there is another way we
> can achieve that, switching to root is not necessary. Any other
> alternative way?  Thanks!
>
> Mao Chuan Li

Hi,

I cannot think of a way; on the other hand, I don't think disabling the 
core dump is necessary either. Simply filtering out '(core dumped) ' is 
not pretty but still suffices for me (we can put that into a filter 
function in common.filter and if other people see other messages for a 
core dump, they can expand that list).

If we really want to disable core dumps, we should change qemu-io not to 
use abort() on -c abort (raise(SIGKILL) seems like a good alternative to 
me); or, alternatively, introduce a new command 'kill' which then does 
raise(SIGKILL) so we don't have to break compatibility.

Max

Re: [Qemu-devel] [PATCH v1 RFC 4/9] qemu-iotests: fix test 039

[Michael Mueller]

On Thu, 13 Nov 2014 18:36:56 +0800
Mao Chuan Li <maochuan@linux.vnet.ibm.com> wrote:

> For successful execution of case 039, core dump need be
> disabled. Just running "ulimit -c 0" command is not enough when the
> /proc/sys/kernel/core_pattern indicates to pipe the dump to another
> application. So we must erase the pattern in addition to the ulimit
> command.
> 
> Reviewed-by:   Michael Mueller <mimu@linux.vnet.ibm.com>
> Signed-off-by: Mao Chuan Li <maochuan@linux.vnet.ibm.com>
> ---
>  tests/qemu-iotests/039 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039
> index 84c9167..bb9382a 100755
> --- a/tests/qemu-iotests/039
> +++ b/tests/qemu-iotests/039
> @@ -34,6 +34,7 @@ status=1	# failure is the default!
>  _cleanup()
>  {
>  	_cleanup_test_img
> +    _restore_core_pattern
>  }
>  trap "_cleanup; exit \$status" 0 1 2 3 15
> 
> @@ -41,6 +42,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>  . ./common.rc
>  . ./common.filter
> 
> +_erase_core_pattern
> +
>  _supported_fmt qcow2
>  _supported_proto file
>  _supported_os Linux

Mao,

you can skip this a and the previous (3/9) patch from the series, please have a look to the patch
Max has posted to solve the issue.

Thanks
Michael