From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrOBG-000159-2V for qemu-devel@nongnu.org; Thu, 20 Nov 2014 04:37:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrOB9-0001dm-Jh for qemu-devel@nongnu.org; Thu, 20 Nov 2014 04:37:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrOB9-0001cE-7C for qemu-devel@nongnu.org; Thu, 20 Nov 2014 04:37:31 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAK9bU02020928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 04:37:30 -0500 Message-ID: <546DB657.9080206@redhat.com> Date: Thu, 20 Nov 2014 10:37:27 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416406785-14241-1-git-send-email-stefanha@redhat.com> <1416406785-14241-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1416406785-14241-5-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.3 4/4] blockdev: acquire AioContext in change-backing-file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf On 2014-11-19 at 15:19, Stefan Hajnoczi wrote: > Add dataplane support to the change-backing-file QMP commands. By > acquiring the AioContext we avoid race conditions with the dataplane > thread which may also be accessing the BlockDriverState. > > Note that this command operates on both bs and a node in its chain > (image_bs). The bdrv_chain_contains(bs, image_bs) check guarantees that > bs and image_bs are in the same AioContext. > > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 19 +++++++++++++------ > hw/block/dataplane/virtio-blk.c | 1 + > 2 files changed, 14 insertions(+), 6 deletions(-) Reviewed-by: Max Reitz