qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, Don Slutz <dslutz@verizon.com>,
	Anthony Liguori <aliguori@amazon.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine vmport=auto: Fix handling of VMWare ioport emulation for xen
Date: Thu, 20 Nov 2014 12:00:19 +0100	[thread overview]
Message-ID: <546DC9C3.4080403@redhat.com> (raw)
In-Reply-To: <20141120100051.GB5983@work-vm>



On 20/11/2014 11:00, Dr. David Alan Gilbert wrote:
>> > I'm still not sure why the configuration should differ for "-M pc"
>> > depending on whether xen is enabled.
> I think this goes back to:
> 
> commit 1611977c3d8fdbdac6090cbd1f5555cee4aed6d9
> Author: Anthony PERARD <anthony.perard@citrix.com>
> Date:   Tue May 3 17:06:54 2011 +0100
> 
>     pc, Disable vmport initialisation with Xen.
>     
>     This is because there is not synchronisation of the vcpu register
>     between Xen and QEMU, so vmport can't work properly.
>     
>     This patch introduces no_vmport parameter to pc_basic_device_init.
>     
>     Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>     Signed-off-by: Alexander Graf <agraf@suse.de>

Yes, but Xen has since implemented vmport (commit 37f9e258).  It's fine
to have a conservative default for "-M xenfv" and possibly "-M pc-2.1",
but "-M pc" can require the latest hypervisor.

Paolo

  reply	other threads:[~2014-11-20 11:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20  0:38 [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine vmport=auto: Fix handling of VMWare ioport emulation for xen Don Slutz
2014-11-20  0:58 ` Eduardo Habkost
2014-11-20  6:04   ` Paolo Bonzini
2014-11-20 10:00     ` Dr. David Alan Gilbert
2014-11-20 11:00       ` Paolo Bonzini [this message]
2014-11-20 15:01         ` Eduardo Habkost
2014-11-20 16:48         ` Don Slutz
2014-11-20 15:07     ` Don Slutz
2014-11-20 15:10       ` Paolo Bonzini
2014-11-20 15:02   ` Don Slutz
2014-11-20  4:11 ` Eric Blake
2014-11-20  9:13   ` Michael S. Tsirkin
2014-11-20 15:16     ` Don Slutz
2014-11-20 15:29       ` Eduardo Habkost
2014-11-20  8:44 ` Michael S. Tsirkin
2014-11-20 16:51   ` Eric Blake
2014-11-20 17:40   ` Don Slutz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546DC9C3.4080403@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=dgilbert@redhat.com \
    --cc=dslutz@verizon.com \
    --cc=ehabkost@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).