From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrPTY-0007sv-Jg for qemu-devel@nongnu.org; Thu, 20 Nov 2014 06:00:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrPTQ-0007iP-Lk for qemu-devel@nongnu.org; Thu, 20 Nov 2014 06:00:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrPTQ-0007i4-E1 for qemu-devel@nongnu.org; Thu, 20 Nov 2014 06:00:28 -0500 Message-ID: <546DC9C3.4080403@redhat.com> Date: Thu, 20 Nov 2014 12:00:19 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1416443890-20263-1-git-send-email-dslutz@verizon.com> <20141120005824.GH3243@thinpad.lan.raisama.net> <546D8450.2080900@redhat.com> <20141120100051.GB5983@work-vm> In-Reply-To: <20141120100051.GB5983@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine vmport=auto: Fix handling of VMWare ioport emulation for xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: Eduardo Habkost , "Michael S. Tsirkin" , Michael Tokarev , qemu-devel@nongnu.org, Don Slutz , Anthony Liguori , Stefan Hajnoczi On 20/11/2014 11:00, Dr. David Alan Gilbert wrote: >> > I'm still not sure why the configuration should differ for "-M pc" >> > depending on whether xen is enabled. > I think this goes back to: > > commit 1611977c3d8fdbdac6090cbd1f5555cee4aed6d9 > Author: Anthony PERARD > Date: Tue May 3 17:06:54 2011 +0100 > > pc, Disable vmport initialisation with Xen. > > This is because there is not synchronisation of the vcpu register > between Xen and QEMU, so vmport can't work properly. > > This patch introduces no_vmport parameter to pc_basic_device_init. > > Signed-off-by: Anthony PERARD > Signed-off-by: Alexander Graf Yes, but Xen has since implemented vmport (commit 37f9e258). It's fine to have a conservative default for "-M xenfv" and possibly "-M pc-2.1", but "-M pc" can require the latest hypervisor. Paolo