From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57933)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XrRQv-0000Lb-P7
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 08:06:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XrRQq-0006Mc-SQ
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 08:06:01 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:35721)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XrRQq-0006FZ-37
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 08:05:56 -0500
Message-ID: <546DE71C.1090303@huawei.com>
Date: Thu, 20 Nov 2014 21:05:32 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1395317703-10412-1-git-send-email-arei.gonglei@huawei.com>
	<87vbv7heed.fsf@elfo.mitica>
	<33183CC9F5247A488A2544077AF1902086C1457B@SZXEMA503-MBS.china.huawei.com>
	<546DD0DB.4010607@redhat.com> <546DD2DF.4090005@huawei.com>
	<20141120123056.GG9190@grmbl.mre> <20141120123553.GG5983@work-vm>
	<20141120130019.GH9190@grmbl.mre>
In-Reply-To: <20141120130019.GH9190@grmbl.mre>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] migration: static variables will not be
 reset at second migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "chenliang (T)" <chenliang88@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "quintela@redhat.com" <quintela@redhat.com>

On 2014/11/20 21:00, Amit Shah wrote:

> On (Thu) 20 Nov 2014 [12:35:54], Dr. David Alan Gilbert wrote:
>> * Amit Shah (amit.shah@redhat.com) wrote:
>>> On (Thu) 20 Nov 2014 [19:39:11], Gonglei wrote:
>>>>>>>> The static variables in migration_bitmap_sync will not be reset in
>>>>>>>> the case of a second attempted migration.
>>>>>>>>
>>>>>>>> Signed-off-by: ChenLiang <chenliang88@huawei.com>
>>>>>>>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>>>>>>>
>>>>>>> Good catch.  Applied..
>>>>>>>
>>>>>>
>>>>>> Hi, Juan? Ping... please :)
>>>>>
>>>>> Juan, what happened to this patch?
>>>>
>>>> Nearly for half a year, I forgot it completely :(
>>>> Thanks for your prompt, Paolo.
>>>
>>> Yeah; unfortunate.
>>>
>>> I feel the patch could've been done in a better way, but since it's
>>> been a while...
>>>
>>> Paolo, Dave, can you please give me r-b and I'll pick it up for 2.2.
>>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 
> Thanks; pull req sent.
> 
> 		Amit

Thanks :)

Best regards,
-Gonglei