From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32897)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1XrTTT-0004nv-DE
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 10:16:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1XrTTN-00007Q-Eh
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 10:16:47 -0500
Received: from fldsmtpe04.verizon.com ([140.108.26.143]:35586)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1XrTTN-00007J-A1
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 10:16:41 -0500
From: Don Slutz <dslutz@verizon.com>
Message-ID: <546E05D5.7080005@terremark.com>
Date: Thu, 20 Nov 2014 10:16:37 -0500
MIME-Version: 1.0
References: <1416443890-20263-1-git-send-email-dslutz@verizon.com>
	<546D69FD.2050006@redhat.com> <20141120091324.GB4050@redhat.com>
In-Reply-To: <20141120091324.GB4050@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine
 vmport=auto: Fix handling of VMWare ioport emulation for xen
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org, Don Slutz <dslutz@verizon.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@amazon.com>

On 11/20/14 04:13, Michael S. Tsirkin wrote:
> On Wed, Nov 19, 2014 at 09:11:41PM -0700, Eric Blake wrote:
>> On 11/19/2014 05:38 PM, Don Slutz wrote:
>>> c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
>>>
>>> or
>>>
>>> c/s b154537ad07598377ebf98252fb7d2aff127983b
>>>
>>> moved the testing of xen_enabled() from pc_init1() to
>>> pc_machine_initfn().
>>>
>>> xen_enabled() does not return the correct value in
>>> pc_machine_initfn().
>>>
>>> Changed vmport from a bool to an enum.  Added the value "auto" to do
>>> the old way.
>>>
>>> +++ b/qapi-schema.json
>>> @@ -3513,3 +3513,19 @@
>>>   # Since: 2.1
>>>   ##
>>>   { 'command': 'rtc-reset-reinjection' }
>>> +
>>> +##
>>> +# @vmport
>>> +#
>>> +# An enumeration of the options on enabling of VMWare ioport emulation
>>> +#
>>> +# @auto: system selects the old default
>>> +#
>>> +# @on: provide the vmport device
>>> +#
>>> +# @off: do not provide the vmport device
>>> +#
>>> +# Since: 2.2
>>> +##
>>> +{ 'enum': 'vmport',
>> All other enums in .json files are named in StudlyCaps.  Please name
>> this starting with a capital letter, and reserve all-lower-case names
>> for commands and built-in types.
> Hi Eric,
> The values here are not vmport-specific.
> Do you think we should have a generic OnOffAuto type?
>

I am waiting for a a clear direction on how to go.

VMPortConfig, Tristate, and OnOffAuto are the 3 names
I am tracking.

    -Don Slutz


>> -- 
>> Eric Blake   eblake redhat com    +1-919-301-3266
>> Libvirt virtualization library http://libvirt.org
>>
>