From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrTap-0000YG-D2 for qemu-devel@nongnu.org; Thu, 20 Nov 2014 10:24:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrTak-0002ON-4F for qemu-devel@nongnu.org; Thu, 20 Nov 2014 10:24:23 -0500 Received: from fldsmtpe04.verizon.com ([140.108.26.143]:46817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrTak-0002OJ-0N for qemu-devel@nongnu.org; Thu, 20 Nov 2014 10:24:18 -0500 From: Don Slutz Message-ID: <546E079F.8030802@terremark.com> Date: Thu, 20 Nov 2014 10:24:15 -0500 MIME-Version: 1.0 References: <1416418257-10166-1-git-send-email-dslutz@verizon.com> <546CD4F1.4040602@redhat.com> <546CDC46.8050603@terremark.com> <546CDCAD.9030800@redhat.com> <546CEA98.40505@terremark.com> <20141120151346.GJ3243@thinpad.lan.raisama.net> In-Reply-To: <20141120151346.GJ3243@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/i386/pc_piix.c: Also pass vmport=off for xenfv machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Don Slutz Cc: Anthony Liguori , "Michael S. Tsirkin" , Michael Tokarev , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Stefan Hajnoczi , Paolo Bonzini On 11/20/14 10:13, Eduardo Habkost wrote: > On Wed, Nov 19, 2014 at 02:08:08PM -0500, Don Slutz wrote: >> On 11/19/14 13:08, Paolo Bonzini wrote: >>> On 19/11/2014 19:07, Don Slutz wrote: >>>>> "-M pc -machine accel=xen" should work and, if that's what you want, >>>>> disable the vmport device. I think this patch is wrong. >>>>> >>>>> Paolo >>>> Well, I also want "-M pc -machine accel=xen,vmport=on" to work. >>> Right. So let's start by deciding what the desired semantics are for >>> all six cases: -M pc/xenfv, -machine vmport=on/off/absent. >>> >>> Paolo >> I get 12 cases (PCMachineState *pcms = PC_MACHINE(obj)): > We have more cases, if we consider "-M pc-2.1" too. > > With this first patch (the one changing default_machine_opts), I expect > to get the following results: > > -M pc > pcms->vmport is true > -M pc -machine vmport=on > pcms->vmport is true > -M pc -machine vmport=off > pcms->vmport is false > -M pc-2.1 > pcms->vmport is true > -M pc-2.1 -machine vmport=on > pcms->vmport is true > (but it doesn't matter, QEMU 2.1 didn't have the vmport option) > -M pc-2.1 -machine vmport=off > pcms->vmport is false > (but it doesn't matter, QEMU 2.1 didn't have the vmport option) > -M xenfv > pcms->vmport is false > -M xenfv -machine vmport=on > pcms->vmport is true > -M xenfv -machine vmport=off > pcms->vmport is false > > -M pc -machine accel=xen > pcms->vmport is true > -M pc -machine vmport=on,accel=xen > pcms->vmport is true > -M pc -machine vmport=off,accel=xen > pcms->vmport is false > -M pc-2.1 -machine accel=xen > pcms->vmport is true ** > -M pc-2.1 -machine vmport=on,accel=xen > pcms->vmport is true > (but it doesn't matter, QEMU 2.1 didn't have the vmport option) > -M pc-2.1 -machine vmport=off,accel=xen > pcms->vmport is false > (but it doesn't matter, QEMU 2.1 didn't have the vmport option) > -M xenfv -machine accel=xen > pcms->vmport is false > -M xenfv -machine vmport=on,accel=xen > pcms->vmport is true > -M xenfv -machine vmport=off,accel=xen > pcms->vmport is false > > I believe there's no consensus yet about the one marked with "**" above. It > boils to the question: do we need to keep guest ABI stability when using > "-M pc-2.1 -machine accel=xen"? > My answer is that for "**" vmport needs to be off. It looks like my response: > Subject: Re: [BUGFIX][PATCH for 2.2 1/1] hw/i386/pc_piix.c: Also pass vmport=off for xenfv machine > Date: Thu, 20 Nov 2014 10:09:31 -0500 > From: Don Slutz > To: Paolo Bonzini , Don Slutz , qemu-devel , Eduardo Habkost > > On 11/20/14 01:02, Paolo Bonzini wrote: > > > > On 19/11/2014 20:08, Don Slutz wrote: > >> -M pc -machine accel=xen > >> pcms->vmport is false > > I think this should be true. Any reason why not? > > > > Paolo > > Yes, QEMU will crash if xen is enabled and the guest tries to access the > VMware port. > > (more on different thread). > > -Don Slutz Was not seen before this. -Don Slutz