From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrURR-0006K4-Q8 for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:18:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrURL-00048F-Ka for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:18:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrURL-00048B-E5 for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:18:39 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKGIbw9013134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 11:18:37 -0500 Message-ID: <546E145A.5080603@redhat.com> Date: Thu, 20 Nov 2014 17:18:34 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416497234-29880-1-git-send-email-kwolf@redhat.com> <1416497234-29880-10-git-send-email-kwolf@redhat.com> In-Reply-To: <1416497234-29880-10-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 9/9] qemu-iotests: Test writing non-raw image headers to raw image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: jcody@redhat.com, armbru@redhat.com, stefanha@redhat.com On 2014-11-20 at 16:27, Kevin Wolf wrote: > This is forbidden if the raw driver was probed. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/109 | 132 +++++++++++++ > tests/qemu-iotests/109.out | 231 ++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/sample_images/grub_mbr.raw.bz2 | Bin 0 -> 552 bytes > 4 files changed, 364 insertions(+) > create mode 100755 tests/qemu-iotests/109 > create mode 100644 tests/qemu-iotests/109.out > create mode 100644 tests/qemu-iotests/sample_images/grub_mbr.raw.bz2 Looking at the hexdump of the grub_mbr.raw, it looks like GRUB 2 to me (when comparing it to my MBR and a GRUB Legacy boot sector; I wasn't so sure whether you might go for GRUB Legacy as a late protest against GRUB 2). Good. :-) Reviewed-by: Max Reitz