From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrUx4-0003Rq-BP for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:51:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrUx2-0003WG-FT for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:51:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrUx2-0003Vr-91 for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:51:24 -0500 Message-ID: <546E1C02.3030909@redhat.com> Date: Thu, 20 Nov 2014 09:51:14 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416443890-20263-1-git-send-email-dslutz@verizon.com> <20141120084414.GA3142@redhat.com> In-Reply-To: <20141120084414.GA3142@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VUhbdhjVjt9CQUshUlPv6EC58P04wjxK7" Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine vmport=auto: Fix handling of VMWare ioport emulation for xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Don Slutz Cc: Eduardo Habkost , Michael Tokarev , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Stefan Hajnoczi , Paolo Bonzini , lcapitulino@redhat.com, mdroth@linux.vnet.ibm.com, Anthony Liguori This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VUhbdhjVjt9CQUshUlPv6EC58P04wjxK7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/20/2014 01:44 AM, Michael S. Tsirkin wrote: > On Wed, Nov 19, 2014 at 07:38:10PM -0500, Don Slutz wrote: >> c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4 >> >> or >> >> c/s b154537ad07598377ebf98252fb7d2aff127983b >> >> moved the testing of xen_enabled() from pc_init1() to >> pc_machine_initfn(). >> >> xen_enabled() does not return the correct value in >> pc_machine_initfn(). >> >> Changed vmport from a bool to an enum. Added the value "auto" to do >> the old way. >> >> Signed-off-by: Don Slutz >=20 > This looks fine to me. A couple of minor comments below. > Also this changes qapi schema file, let's get ack from maintainers - > my understanding is that just adding a definition there won't > affect any users, correct? Correct; adding a definition won't break existing users, whether or not the new type is currently used by current commands. However, it's still worth designing the new enum type to be potentially reusable; the idea of naming it OnOffAuto makes sense to me. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VUhbdhjVjt9CQUshUlPv6EC58P04wjxK7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUbhwCAAoJEKeha0olJ0Nq2V8H/36Gm5aAytqP8kyUIhEgm0WT X9FhHX8/ooEKwy8IgNyDcEkZUUuTRdUlAh/o8t+wEI4fsUvROk0FtZrbLzcbqoPY OUgLIQGgeTLk8Cf0wsnImAJybJ49yX+72HMJtojIcGvJkY428tua8VexpNWDwxC/ 78Mxm/CHO/jdD5QrASvyS+NO9ABUiptUm9gdqSt5k3SJbFQs/DW6WY83+HV0E5+U A2sWCsWvKsmOnYmY/3X6CrMlE3oags+wbWXsHMCVBAT6yLNQb5s+r7r7ex+cTrFb f1PnHulfEvJJCkf9NTapk6+QztShjnWw5chUHd6VUANOHo9dor3byLgo8d/Kvcs= =Qgop -----END PGP SIGNATURE----- --VUhbdhjVjt9CQUshUlPv6EC58P04wjxK7--